After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 127235 - [PATCH] aisleriot freecell doesn't handle supermove
[PATCH] aisleriot freecell doesn't handle supermove
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.4.x
Other Linux
: Normal normal
: ---
Assigned To: Rosanna Yuen
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2003-11-17 22:10 UTC by Juri Pakaste
Modified: 2012-01-31 23:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A patch to add supermove support (878 bytes, patch)
2003-11-17 22:11 UTC, Juri Pakaste
none Details | Review
A better supermove patch that handles the cases where the originating or destination field is empty (1.43 KB, patch)
2003-11-18 17:27 UTC, Juri Pakaste
none Details | Review

Description Juri Pakaste 2003-11-17 22:10:41 UTC
Aisleriot freecell doesn't know how to do a supermove
(http://home.earthlink.net/~fomalhaut/fcfaq.html#Supermove). I'm attaching
a patch to fix this.
Comment 1 Juri Pakaste 2003-11-17 22:11:51 UTC
Created attachment 21553 [details] [review]
A patch to add supermove support
Comment 2 Juri Pakaste 2003-11-17 22:21:31 UTC
Oh, and as probably is evident from the patch, it's against Aisleriot
2.4.1.
Comment 3 Juri Pakaste 2003-11-18 07:38:07 UTC
Bah, I just realized this probably overestimates the user's ability to
move cards when 1) moving from a field that's left empty after the
column is moved and 2) when moving into and empty field.
Comment 4 Juri Pakaste 2003-11-18 17:25:32 UTC
Attaching a new patch, this one should deal correctly with those cases.
Comment 5 Juri Pakaste 2003-11-18 17:27:42 UTC
Created attachment 21597 [details] [review]
A better supermove patch that handles the cases where the originating or destination field is empty
Comment 6 Callum McKenzie 2003-11-19 01:52:51 UTC
I've applied the patch and it should appear in CVS tonight.

Thanks a lot for doing this. Several people had asked for it and I was
still trying to figure out exactly what was needed.

Comment 7 Robert Ancell 2012-01-31 23:14:13 UTC
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component.  Apologies for the mass email!