GNOME Bugzilla – Bug 126967
[PATCH] mpegdemux PTS parsing wrong
Last modified: 2005-08-15 01:53:49 UTC
Hi *, The mpegdemux element parses presentation timestamps wrong, especially ones which are higher than what is found in common mpeg files. The attached patch fixes this. As well as removing the "provided clock" from the demuxer, as it effectively provides no clock since long. The specific get_clock() call returns NULL by default. So that I removed the few things that were still related to the spooky provided clock. Greets, Martin
Created attachment 21443 [details] [review] patch file
Adding the PATCH keyword and upgrading the priority to High due to the attached patch.
Thanks for the patch. Can you please re-attach it in diff -u format? I'll apply it a.s.a.p. then.
Ohwell, just re-typed it. Thanks for the patch, it's in HEAD/CVS now.
Created attachment 22881 [details] [review] fix for more integer overflows
Hi again, thx for patching it in, i nearly forgot about this. There are similar errors in mpegdemux and mpegparse, see previously attached patch.
I don't think the non-64 bit ones are needed. Note that a copy of a 8-bit integer will (on-stack) always be 32-bit. Anyway, I still applied it because it won't really hurt and the compiler will probably optimize these things away for us.