GNOME Bugzilla – Bug 126068
the properties should always display the "Contents"
Last modified: 2006-01-08 12:55:47 UTC
Please add a button to the properties window to count the number and size of the selected files when "count number of itemss" is disabled in the preferences.
I'm not sure than the button is a good option, but the properties should probably always display the count. I'm changing the summary to reflect that. Let me know if you agree of if you think than a button would be a better choice
*** Bug 167146 has been marked as a duplicate of this bug. ***
Yeah, making the folder properties always display the folder size and count even if the "count number of items" is turned off is something I have always wanted. I don't display the count of folders in the folder view but I want the properties to show it. The way it works now I have to enable "count number of items" anyway because else I don't get size and count in properties, but it slows down interaction in folders that contain many sub folders which is irritating (it can take over 10 seconds to open a sub folder in a folder that contains several hundreds of sub folders, but with "count number of items" turned off it is instant).
This sounds like a useful proposal. nautilus_file_get_deep_counts unfortunately returns if nautilus_file_should_show_directory_item_count is FALSE, which toggles based on the preference. Maybe nautilus_file_get_deep_counts should take a gboolean force parameter.
Created attachment 51787 [details] [review] Proposed patch Some remarks: - Removed properties window code which toggles the visibility of the deep count field - Added "force" flag to nautilus_file_get_deep_counts - - string getters pass FALSE - - the property window passes TRUE - - all nautilusfile_class->get_deep_counts implementations pass TRUE, since their deep count getters are always beyond the check in nautilus_file_get_deep_counts. I'm not sure whether the trash implementation should be special-cased and only pass TRUE for local files, so that remote locations in the trash still obey the pref.
*** Bug 316030 has been marked as a duplicate of this bug. ***
I've committed the patch. This change will make it into Nautilus 2.12.1.
> I'm not sure than the button is a good option, but the properties should probably always display the count. I'm changing the summary to reflect that. Let me know if you agree of if you think than a button would be a better choice I let you know that a button is by far a better choice : the counting of items of a directory is a *quite* heavy task in term of CPU usage and system calls. Such a heavy task for a rarely usefull information is a very bad idea : if a user really want such an information, he/she would click on a Compute (for example) button. Think about asking the property of a item when a network filesystem via FTP or SFTP... Think about people asking why their disk become noisy each time they ask for a directory property ... Think about people why low-end computer which get on its knees each time a user ask for directory's properties. A button (or the disabling of the "count number of item" if it is set to "Never") is IMHO the way to go.