After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 125857 - It would be nice to be able to re-order process columns
It would be nice to be able to re-order process columns
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2003-10-30 19:18 UTC by Raul Acevedo
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.93 KB, patch)
2004-11-18 20:09 UTC, Benoît Dejean
committed Details | Review

Description Raul Acevedo 2003-10-30 19:18:27 UTC
It'd be great to be able to drag the process column tabs around to re-order
them.  Is this possible via the (hopefully) generic widget used to display
the process columns?
Comment 1 Raul Acevedo 2004-11-18 18:42:10 UTC
Given the overwhelming response to this bug  :)  maybe instead re-ordering the
columns at the very least the "process args" column could always be made the
last one on the right, instead of the first one on the left.  That's really the
one that gets to me.... I run this program all the time in its own workspace,
and while the Process Arguments column is extremely useful, since it always
pushes everything else out of view, I only display it when I absolutely need it. 
Comment 2 Raul Acevedo 2004-11-18 19:34:13 UTC
Ok, I modified the source to make Arguments be the last column.  What's the
easiest way to make a patch file from the emacs backup files?  I modified
proctable.c and proctable.h.
Comment 3 Benoît Dejean 2004-11-18 20:00:22 UTC
cvs howto http://developer.gnome.org/tools/cvs.html

then

cvs diff -u > mypatch

i think the patch should be very easy, but it would be great if you could attach
something :) (i'm pretty busy and you're right)

Thanks for your help
Comment 4 Benoît Dejean 2004-11-18 20:09:02 UTC
Created attachment 33914 [details] [review]
proposed patch
Comment 5 Raul Acevedo 2004-11-22 20:01:31 UTC
My patch is pretty much identical to yours (save for line breaks).  I added
comments to "model = gtk_tree_store_new" so it looks like:

	model = gtk_tree_store_new (NUM_COLUMNS,
				    G_TYPE_STRING /* Name */,
				    G_TYPE_STRING /* User */,
				    G_TYPE_STRING /* Status */,
				    G_TYPE_STRING /* Memory */,
				    G_TYPE_STRING /* VM Size */,
				    G_TYPE_STRING /* Resident Memory */,
				    G_TYPE_STRING /* Shared Memory */,
				    G_TYPE_STRING /* RSS Memory */,
				    G_TYPE_STRING /* X Server Memory */,
				    G_TYPE_INT /* CPU */,
				    G_TYPE_INT /* Nice */,
				    G_TYPE_INT /* ID */,
				    G_TYPE_STRING /* Arguments */,
				    GDK_TYPE_PIXBUF, G_TYPE_POINTER);		    

which you might want to incorporate, so next time a new person tries to modify
the code they don't spend an hour wondering why the app crashes after two
seconds before they realize that the data types have to be adjusted in this list
also.  :)

Looks like your patch, based on CVS, adds a "Security Context" thing... what is
that about?

Oh, since my patch is more or less the same as yours, I won't bother putting it
here, as long as I know you'll submit your changes.  Thanks!
Comment 6 Benoît Dejean 2004-11-22 20:06:48 UTC
you're right, i lose myself everytime i hack the column layout.
i've commited a few days ago, but the bug is still open :)

(Security Context : http://bugzilla.gnome.org/show_bug.cgi?id=150020)
Comment 7 Benoît Dejean 2004-11-27 14:11:54 UTC
Now, it's reorderable but i don't know how save user-defines order :/
Comment 8 Loïc Minier 2005-06-03 19:09:09 UTC
I tried moving the columns in current G 2.8 gsm, and I couldn't.  Was this
reorder code commited and then removed?
Comment 9 Benoît Dejean 2005-06-03 19:20:17 UTC
current is 2.10 :) 2.8 hasn't reorderable columns.
Comment 10 Benoît Dejean 2005-06-10 13:51:25 UTC
Done (save/restore columns order). Checkout 2.11.4 (CVS HEAD).