GNOME Bugzilla – Bug 125660
Creating new profile changes title of based on profiles window
Last modified: 2005-09-19 11:26:51 UTC
After doing a portupgrade on Gnome Terminal ( from 2.4 to 2.4.1 ) this weekend I am having some strange problems. Firstly, I can't open a terminal to one of my servers with "Custom command" set to "ssh -l user ip" whereas I could before. I tried creating a new "test" account based on my local account and then all of a sudden every tab ( session open ) changed it's name to the "test" profile I created. The account I could login to before opens a new tab for a second then it disappears. Running the command from local session command line works fine so it's not a ssh configure problem and nothing has changed on the remote machine. If I edit profiles from the list then they have their usual title settings but any sessions that I have open have a different title to what they have in the list. Creating new profiles causes the title on my open sessions to change randomly to another existing profiles title.
My apologies on the "not being able to open a terminal" part in the above report. That was my fault, running the same command via xterm I was able to see what the problem was. The actual title changes still stand though and has been confirmed by another user. Sorry about that.
I can reproduce this. When creating a new profile (called 'new_profile'), based on profile called 'old_profile' the title of every 'old_profile' window/tab will be changed. This change is only for the *initial* title, it won't happen when the initlial title has been changed (things like PS1/PROMPT_COMMAND). It seems that the old_profile windows switch to the new_profile. Not sure, so I'm not adding that in the summary. Steps to reproduce (there are other -easier- ways to reproduce this): 1. Goto: Edit->Profiles 2. Click on: New 3. In Profile name, enter: old_profile 4. From 'Base on', select: Default 5. Goto: Title and command 6. From 'Dynamically-set title', select: Isn't displayed 7. Click Close (the profile window) 8. Click Close (the Edit profiles window) 9. Select: File->New window->old_profile -- new window appears.. stay in that window 10. Goto: Edit-Profiles 11. Click on: New 12. In Profile name, enter: new_profile 13. From 'Base on', select: old_profile -- title of the old_profile window changes to new_profile 14. Goto: Title and command 15. In Initial title, add: foobarfoobar -- title of the old_profile window changes 16. Click Close (the profile window) 17. Click Close (the Edit profiles window) File->New window from the old_profile window (now with title new_profilefoobarfoobar), new_profile is at the top. Seems that the window has changed profiles somehow. gnome-terminal & vte from anoncvs yesterday.
Created attachment 50601 [details] [review] Patch that fixes the New Profile command.
This bug was annoying me, so I dug in and fixed it (see patch above). Basically, it was passing in a list of new profiles to sync_profile_list, whereas it should have been passing a list of all profiles. So all the windows thought the new profile was the *only* profile. I'm pretty sure this will also fix bug #164378, though I don't know enough about sessions to test it.
Wow, I'm impressed this bug has been open all this time and finally been squashed :-) I patched my gentoo system and all is well in the land of gnome-terminal. Thanks.
It sure does fix both bugs here. Marking the other as duplicate and closing. Patch commited to CVS. Thanks a lot.
*** Bug 164378 has been marked as a duplicate of this bug. ***
*** Bug 158031 has been marked as a duplicate of this bug. ***