After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 125046 - "Help not found" message should be in a dialog
"Help not found" message should be in a dialog
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonoboui
CVS HEAD
Other Linux
: Low enhancement
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2003-10-20 16:09 UTC by J.H.M. Dassen (Ray)
Modified: 2007-11-13 21:48 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
simple patch (1006 bytes, patch)
2007-09-08 20:38 UTC, Matthias Clasen
committed Details | Review

Description J.H.M. Dassen (Ray) 2003-10-20 16:09:15 UTC
(Based on Debian bug #216588)

The diagnostic message for when the documentation is not found
  (gnumeric:1407): Bonobo-WARNING **: Error: 'Unable to find the help
  files in either
  /usr/share/gnumeric/1.1.19-bonobo/share/gnome/help/gnumeric/ or
  /usr/share/gnome/help/.  Please check your installation'
is output on stdout/stderr. It would be better if this were put in a dialog
as with other diagnostics.
Comment 1 Andreas J. Guelzow 2003-10-21 13:20:58 UTC
This isn't really a gnumeric issue. This warning/error is being
created by bonobo.
Comment 2 Jody Goldberg 2003-10-22 06:14:32 UTC
lets see if michael has any ideas
Comment 3 Michael Meeks 2003-10-27 10:09:44 UTC
If you want to turn that into an error dialog you're welcome; the
dialog should perhaps say something more friendly like:

"Your packager screwed up badly and didn't ship the docs" ;->

Not convinced this is that useful. The problems of which display /
screen to put the error on etc. are not completely obvious so ...
Comment 4 Luis Villa 2004-02-21 18:34:12 UTC
Switching QA maint to an alias that points at me for easier sorting. Search on
'louie doing alias spam' to find all emails and mark read.
Comment 5 Matthias Clasen 2007-09-08 20:38:08 UTC
Created attachment 95189 [details] [review]
simple patch
Comment 6 Michael Meeks 2007-09-10 11:09:14 UTC
Looks lovely to me, do commit at whim to bonobo* Matthias :-)
Comment 7 Christian Persch 2007-09-10 11:39:14 UTC
+gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
+  error->message);

..., "%s", error->message);
unless you can guarantee that error->message doesn't contains any % characters.
Comment 8 J.H.M. Dassen (Ray) 2007-11-11 21:39:53 UTC
I've taken the liberty of committing the corrected patch:
	http://svn.gnome.org/viewvc/libbonoboui/trunk/bonobo/bonobo-ui-util.c?r1=2511&r2=2550
Comment 9 J.H.M. Dassen (Ray) 2007-11-12 06:29:19 UTC
And of disabling it for now as it breaks a string freeze.
Comment 10 Christian Persch 2007-11-13 21:48:05 UTC
I branched libbonoboui and fixed the code on branch and trunk.