GNOME Bugzilla – Bug 125046
"Help not found" message should be in a dialog
Last modified: 2007-11-13 21:48:05 UTC
(Based on Debian bug #216588) The diagnostic message for when the documentation is not found (gnumeric:1407): Bonobo-WARNING **: Error: 'Unable to find the help files in either /usr/share/gnumeric/1.1.19-bonobo/share/gnome/help/gnumeric/ or /usr/share/gnome/help/. Please check your installation' is output on stdout/stderr. It would be better if this were put in a dialog as with other diagnostics.
This isn't really a gnumeric issue. This warning/error is being created by bonobo.
lets see if michael has any ideas
If you want to turn that into an error dialog you're welcome; the dialog should perhaps say something more friendly like: "Your packager screwed up badly and didn't ship the docs" ;-> Not convinced this is that useful. The problems of which display / screen to put the error on etc. are not completely obvious so ...
Switching QA maint to an alias that points at me for easier sorting. Search on 'louie doing alias spam' to find all emails and mark read.
Created attachment 95189 [details] [review] simple patch
Looks lovely to me, do commit at whim to bonobo* Matthias :-)
+gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog), + error->message); ..., "%s", error->message); unless you can guarantee that error->message doesn't contains any % characters.
I've taken the liberty of committing the corrected patch: http://svn.gnome.org/viewvc/libbonoboui/trunk/bonobo/bonobo-ui-util.c?r1=2511&r2=2550
And of disabling it for now as it breaks a string freeze.
I branched libbonoboui and fixed the code on branch and trunk.