After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 124419 - register GdaProviderInfo and GdaDataSourceInfo boxed types
register GdaProviderInfo and GdaDataSourceInfo boxed types
Status: RESOLVED FIXED
Product: libgda
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Rodrigo Moya
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-10-12 12:36 UTC by Murray Cumming
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
boxed_types.patch (4.56 KB, patch)
2003-10-12 12:37 UTC, Murray Cumming
none Details | Review

Description Murray Cumming 2003-10-12 12:36:04 UTC
This patch ensures that the GdaProviderInfo and GdaDataSourceInfo types are
registered as GTypes, with copy and free functions. This is helpful for
language bindings.
Comment 1 Murray Cumming 2003-10-12 12:37:14 UTC
Created attachment 20654 [details] [review]
boxed_types.patch
Comment 2 Rodrigo Moya 2003-10-12 13:22:06 UTC
Looks good, except for the code formatting, which does not follow the
same style as the other code in the same file. So please fix the
formatting of the code, and commit, to 1-0 branch and HEAD, if possible.
Comment 3 Murray Cumming 2003-10-13 19:35:43 UTC
Do you just mean
- the tabs instead of 2 spaces
- no space before the open bracket, in a couple of places
?
Comment 4 Rodrigo Moya 2003-10-13 20:02:16 UTC
tabs instead of 2 spaces, opening bracket (for everything but
functions) in the same line as the statement it belongs to, etc. I
think the HACKING file has a full description of the format.
Comment 5 Murray Cumming 2003-10-14 15:46:47 UTC
Committed to both branches.