After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 124236 - Missing warning when downloading to not writable directory
Missing warning when downloading to not writable directory
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: 1.6
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2003-10-09 19:37 UTC by 9sott
Modified: 2005-05-29 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add alerts. (2.48 KB, patch)
2005-05-28 20:33 UTC, Jean-François Rameau 		needs-work Details | Review
Title and icon (2.77 KB, patch)
2005-05-28 21:26 UTC, Jean-François Rameau 		accepted-commit_now Details | Review

Description 9sott 2003-10-09 19:37:57 UTC 
Epiphany 1.0 doesn't warn if user want to download a file to not writable
directory (etc regular user "/"). 
File is downloaded.
Comment 1 Christian Persch 2004-08-23 13:00:15 UTC 
Moving Target Milestone -> 1.6 since this requires string changes.
Comment 2 Christian Persch 2004-10-13 10:51:28 UTC 
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Comment 3 Jean-François Rameau 2005-05-28 20:33:51 UTC 
Created attachment 46979 [details] [review]
Add alerts.

Patch adding two alerts:
- one if the directory is not writable,
- the other if the file the user wants to overwrite is not writable too.
Comment 4 Christian Persch 2005-05-28 20:39:35 UTC 
Thanks for the patch!

The dialogue needs a title.

+if (parent != NULL)
+{
+	gtk_window_group_add_window (
+ 	ephy_gui_ensure_window_group (GTK_WINDOW (parent)),
+				GTK_WINDOW (dialog));
+}

ephy_gui_ensure_window_group (dialog);

Same things apply to the 2nd dialogue.
Comment 5 Jean-François Rameau 2005-05-28 21:26:23 UTC 
Created attachment 46981 [details] [review]
Title and icon

This patch adds a title and sets the icon to the two added alerts.
Comment 6 Christian Persch 2005-05-28 21:53:44 UTC 
-	if (filename == NULL) return FALSE;
+	g_return_val_if_fail (filename != NULL, FALSE);

Let's keep the normal return here, iirc I put it for some reason there (the
filechoose sometimes returns NULL filenames).+		

Ok to commit with that fixed.
Comment 7 Jean-François Rameau 2005-05-29 14:30:51 UTC 
Fixed to CVS HEAD.