After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 124052 - shell_output problems with 'pos' return value
shell_output problems with 'pos' return value
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
0.5.1
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
gedit QA volunteers
Depends on:
Blocks:
 
 
Reported: 2003-10-07 18:51 UTC by Owen Taylor
Modified: 2019-03-23 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fixing pos return value (771 bytes, patch)
2003-10-07 18:52 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2003-10-07 18:51:58 UTC 
(https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104027)

shell_output.c doesn't handle the 'pos' return value from
g_io_channel_read_line() correctly:

 A) It's in bytes, not characters
 B) The pos and length return values need to be size_t/gsize
    not int. (These types are different sizes on 64-bit machines)
Comment 1 Owen Taylor 2003-10-07 18:52:33 UTC 
Created attachment 20548 [details] [review]
Patch fixing pos return value
Comment 2 Paolo Maggi 2003-10-16 16:59:51 UTC 
Owen: thanks for the patch.

Committed in the gnome-2-4 branch.

I have still to commit it in CVS HEAD
Comment 3 Paolo Maggi 2003-10-20 17:59:48 UTC 
Committed to CVS HEAD too.