GNOME Bugzilla – Bug 123719
examples/threads fixed
Last modified: 2004-12-22 21:47:04 UTC
With this patch all gtkmm code in examples/threads/dispatcher.cc and examples/threads/dispatcher2.cc has been casted out, now they only need glimm. Also I fixed configure.in to add examples/threads because they now build and run just fine.
Created attachment 20437 [details] [review] glibmm-2.3.0 examples/thread/dispatcher.cc & examples/thread/dispatcher2.cc no-gtkmm fix
Thanks. The patch is unreadable because you have indented all of the source code lines by 2 spaces, for no reason. I would approve this anyway, but I'd really like to be able to read the changes for my own education.
Also, please don't use g types when it is not necessary: -int main(int argc, char** argv) +int main( gint argc, gchar** argv ) In general, please just change what needs to be changed.
sorry for all my stupid mistakes with my last patch, I'm sending a new one the way it should be...
Created attachment 20447 [details] [review] glibmm-2.3.0 examples/thread/dispatcher.cc & examples/thread/dispatcher2.cc no-gtkmm fixed fix
Great. Someone please commit this. In future, please use the existing coding style (You can see how you have changed it in the patch).
Well I'm both dyslexic and dysgraphic, only a little, but I am. So I that need that extra spaces to work out my phisical disablity. But I will find a way to reformat the code back to it's original form.
Well this is my last (I hope) patch for this code and it has all formating issues from the past patches fixed, so hope it could be merged in glibmm cvs head... Please do so.
Created attachment 20710 [details] [review] glibmm/examples/thread/dispatcher?.cc patch
I'm very sorry. I forgot.
Applied. Thanks.