After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 123250 - "Clean the XML Souce" introduces extra visual whitespace
"Clean the XML Souce" introduces extra visual whitespace
Status: VERIFIED FIXED
Product: conglomerate
Classification: Other
Component: Code
CVS
Other Linux
: High normal
: 1.0.0
Assigned To: conglomerate list
conglomerate list
: 125767 (view as bug list)
Depends on:
Blocks: 123152
 
 
Reported: 2003-09-25 21:48 UTC by David Hoover
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (7.07 KB, patch)
2005-03-18 16:20 UTC, Nickolay V. Shmyrev
none Details | Review

Description David Hoover 2003-09-25 21:48:54 UTC
If you do Tools->Clean XML Source, it introduces extra white space between
elements in the graphical view. This is presumably due to the extra
whitespace it introduces into the file. However, even if it doesn't change
anything (i.e. run it a second time), more whitespace is added each time
you run it.
Comment 1 David Malcolm 2003-09-27 14:02:50 UTC
I believe the repeatedly adding whitespace to the editor view is a bug
deep inside the CongEditorArea creation code.  It ought to be merging
adjacent "inline flow" objects, and removing empty ones from the
parent block flow, but is failing to do this, leaving empty paragraph
objects with zero size, separated by paragraph separator spaces.

Every time you run the Cleanup Source tool it creates, merges and
destroys whitespace TEXT nodes, which gives the above code a through
"workout", and shows up these bugs.
Comment 2 Paul Smith 2003-11-01 10:33:27 UTC
*** Bug 125767 has been marked as a duplicate of this bug. ***
Comment 3 Gabriel de Perthuis 2005-03-15 21:01:46 UTC
Here is a testcase if it can help:

<?xml version="1.0"?>
<!DOCTYPE article PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"
"http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd">
<article>
	<title></title>
			<para>
				<programlisting></programlisting>
			</para>
</article>

Comment 4 Nickolay V. Shmyrev 2005-03-15 23:35:04 UTC
Are you sure that conglomerate still has this bug? The only problem I can see
with recent CVS is warnings like the following:

** (conglomerate:13830): CRITICAL **: cong_command_add_cursor_change: assertion
`cong_location_is_valid (new_location)' failed
Comment 5 Gabriel de Perthuis 2005-03-16 08:48:20 UTC
This was with conglomerate 0.7.16 . I just went CVS to check and it is fixed, I
don't even have an assertion failure.
So you can close the bug!
Comment 6 Nickolay V. Shmyrev 2005-03-18 16:20:02 UTC
Created attachment 38906 [details] [review]
Patch

Those warnings are important since they reflect some unimplemented thins. The
patch above should fix them. 

Also it has side-effect - fix crash of conglomerate with source view open and
document closed.
Comment 7 Dave Malcolm 2005-03-19 05:09:31 UTC
Committed; thanks.
Comment 8 Geert Stappers 2005-05-08 12:31:13 UTC
Is it okay that I close this bugreport?
Comment 9 Nickolay V. Shmyrev 2005-05-08 18:16:59 UTC
Thanks, Geert, it should be solved.