GNOME Bugzilla – Bug 123250
"Clean the XML Souce" introduces extra visual whitespace
Last modified: 2009-08-15 18:40:50 UTC
If you do Tools->Clean XML Source, it introduces extra white space between elements in the graphical view. This is presumably due to the extra whitespace it introduces into the file. However, even if it doesn't change anything (i.e. run it a second time), more whitespace is added each time you run it.
I believe the repeatedly adding whitespace to the editor view is a bug deep inside the CongEditorArea creation code. It ought to be merging adjacent "inline flow" objects, and removing empty ones from the parent block flow, but is failing to do this, leaving empty paragraph objects with zero size, separated by paragraph separator spaces. Every time you run the Cleanup Source tool it creates, merges and destroys whitespace TEXT nodes, which gives the above code a through "workout", and shows up these bugs.
*** Bug 125767 has been marked as a duplicate of this bug. ***
Here is a testcase if it can help: <?xml version="1.0"?> <!DOCTYPE article PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN" "http://www.oasis-open.org/docbook/xml/4.1.2/docbookx.dtd"> <article> <title></title> <para> <programlisting></programlisting> </para> </article>
Are you sure that conglomerate still has this bug? The only problem I can see with recent CVS is warnings like the following: ** (conglomerate:13830): CRITICAL **: cong_command_add_cursor_change: assertion `cong_location_is_valid (new_location)' failed
This was with conglomerate 0.7.16 . I just went CVS to check and it is fixed, I don't even have an assertion failure. So you can close the bug!
Created attachment 38906 [details] [review] Patch Those warnings are important since they reflect some unimplemented thins. The patch above should fix them. Also it has side-effect - fix crash of conglomerate with source view open and document closed.
Committed; thanks.
Is it okay that I close this bugreport?
Thanks, Geert, it should be solved.