GNOME Bugzilla – Bug 122481
[PATCH] wavenc is somehow broken
Last modified: 2004-12-22 21:47:04 UTC
While trying to debug sound-juicer 0.5.3 WAV encoding support, I found this : gst-launch cdparanoia location="/dev/cdrom1" ! wavenc ! filesink location="/tmp/test.wav" INFO ( 7358: 0) Initializing GStreamer Core Library version 0.6.3 INFO ( 7358: 0) CPU features: (c1c7fbff) MMX 3DNOW MMXEXT INFO ( 7358: 0) registry: loaded global_registry in 0.265892 seconds (/var/cache/gstreamer-0.6/registry.xml) GStreamer-INFO: 0 live buffer(s) GStreamer-INFO: 0 live bufferpool(s) GStreamer-INFO: 0 live event(s) RUNNING pipeline ERROR: /pipeline0/wavenc0: encoder not initialised (input is not audio?) execution ended after 1 iterations (sum 635321000 ns, average 635321000 ns, min 635321000 ns, max 635321000 ns) GStreamer-INFO: 0 live buffer(s) GStreamer-INFO: 0 live bufferpool(s) GStreamer-INFO: 0 live event(s) I don't have any problem when I replace wavenc with either lame, vorbisenc or flacenc..
Created attachment 20065 [details] [review] This patch should correct this bug
Makes sense. Applied to HEAD.
No, that patch doesn't make sense. It may work around the bug in that particular case, but it certainly doesn't make sense. (It should still break if you make that pipeline go NULL->PAUSED- >READY->PLAYING). I believe there is bug in the core where caps nego is not done in READY->PAUSED but before, when a padtemplate has fixed caps (like cdparanoia or mu/alawdec.
This patch is applied to 0.6 it seems. Should it be kept open due to Benjamins comment?
Thomas, I'd hesistate to make this a 0.6.4 blocker. Dave's fix largely fixes this in default cases. Benjamin is definately correct, but we can't fix that anytime soon. Maybe we can't fix it at all in 0.6.x due to the ABI constraints...
apoc commited this to 0.6.3.1, closing