After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 122481 - [PATCH] wavenc is somehow broken
[PATCH] wavenc is somehow broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.3
Other Linux
: Normal blocker
: 0.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-09-16 20:54 UTC by Frederic Crozat
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This patch should correct this bug (581 bytes, patch)
2003-09-18 19:55 UTC, Jeremy Simon
none Details | Review

Description Frederic Crozat 2003-09-16 20:54:22 UTC
While trying to debug sound-juicer 0.5.3 WAV encoding support, I found this :

gst-launch cdparanoia location="/dev/cdrom1"  ! wavenc ! filesink
location="/tmp/test.wav"
INFO ( 7358: 0) Initializing GStreamer Core Library version 0.6.3
INFO ( 7358: 0) CPU features: (c1c7fbff) MMX 3DNOW MMXEXT
INFO ( 7358: 0) registry: loaded global_registry in 0.265892 seconds
          (/var/cache/gstreamer-0.6/registry.xml)
GStreamer-INFO: 0 live buffer(s)
GStreamer-INFO: 0 live bufferpool(s)
GStreamer-INFO: 0 live event(s)
RUNNING pipeline
ERROR: /pipeline0/wavenc0: encoder not initialised (input is not audio?)
execution ended after 1 iterations (sum 635321000 ns, average 635321000 ns,
min 635321000 ns, max 635321000 ns)
GStreamer-INFO: 0 live buffer(s)
GStreamer-INFO: 0 live bufferpool(s)
GStreamer-INFO: 0 live event(s)


I don't have any problem when I replace wavenc with either lame, vorbisenc
or flacenc..
Comment 1 Jeremy Simon 2003-09-18 19:55:31 UTC
Created attachment 20065 [details] [review]
This patch should correct this bug
Comment 2 David Schleef 2003-09-19 22:39:49 UTC
Makes sense.  Applied to HEAD.
Comment 3 Benjamin Otte (Company) 2003-09-26 15:03:57 UTC
No, that patch doesn't make sense.
It may work around the bug in that particular case, but it certainly 
doesn't make sense.
(It should still break if you make that pipeline go NULL->PAUSED-
>READY->PLAYING).

I believe there is bug in the core where caps nego is not done in 
READY->PAUSED but before, when a padtemplate has fixed caps (like 
cdparanoia or mu/alawdec.
Comment 4 Christian Fredrik Kalager Schaller 2003-09-27 15:52:15 UTC
This patch is applied to 0.6 it seems. Should it be kept open due to
Benjamins comment?
Comment 5 Ronald Bultje 2003-09-29 08:14:06 UTC
Thomas, I'd hesistate to make this a 0.6.4 blocker. Dave's fix largely
fixes this in default cases. Benjamin is definately correct, but we
can't fix that anytime soon. Maybe we can't fix it at all in 0.6.x due
to the ABI constraints...
Comment 6 Thomas Vander Stichele 2003-10-05 14:22:58 UTC
apoc commited this to 0.6.3.1, closing