Bug 122477 – Can't install custom emblems in nautilus 2.4.x

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 122477 - Can't install custom emblems in nautilus 2.4.x


Summary:	Can't install custom emblems in nautilus 2.4.x


Status:	VERIFIED FIXED

Product:	nautilus
Classification:	Core
Component:	[obsolete] Backgrounds Emblems and Themes
Version:	2.4.x
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	Nautilus Maintainers
QA Contact:	Nautilus Maintainers

URL:
Whiteboard:

Duplicates:	137869 (view as bug list)
Depends on:
Blocks:

Reported:	2003-09-16 19:32 UTC by gashcrumb
Modified:	2009-08-15 18:40 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Patch to fix this problem (848 bytes, patch) 2003-11-10 09:28 UTC, Kiran Kumar Immidi	none	Details \| Review

Description gashcrumb 2003-09-16 19:32:13 UTC

Distribution: Slackware Slackware 9.0.0
Package: nautilus
Severity: normal
Version: GNOME2.4.0 2.4.x
Gnome-Distributor: GNOME.Org
Synopsis: Can't install custom emblems in nautilus 2.4.x
Bugzilla-Product: nautilus
Bugzilla-Component: Backgrounds Emblems and Themes
Bugzilla-Version: 2.4.x
BugBuddy-GnomeVersion: 2.0 (2.4.0.1)
Description:
Description of the crash:

Trying to add custom emblems for nautilus.  The "Backgrounds and
Emblems" dialog doesn't pick up changes when I try and add an emblem,
and dragging new pictures to use as emblems into the emblem sidebar
crashes nautilus.

Steps to reproduce the crash:
1. Open up a directory containing some pixmaps and the emblem sidebar
2. drag a pixmap into the emblem sidebar
3. when prompted give a name to the emblem

Expected Results: nautilus crashes


How often does this happen? every time


Additional Information:



Debugging Information:

Backtrace was generated from '/usr/bin/nautilus'

[New Thread 16384 (LWP 5105)]
[New Thread 32769 (LWP 5108)]
[New Thread 16386 (LWP 5109)]
0x40d10f29 in wait4 () from /lib/libc.so.6

+ Trace 40235

Thread 1 (Thread 16384 (LWP 5105))

#0 wait4
from /lib/libc.so.6
#1 __DTOR_END__
from /lib/libc.so.6
#2 waitpid
from /lib/libpthread.so.0
#3 libgnomeui_segv_handle
at gnome-ui-init.c line 738
#4 __pthread_sighandler
from /lib/libpthread.so.0
#5 <signal handler called>
#6 nautilus_emblem_verify_keyword
at nautilus-emblem-utils.c line 196
#7 nautilus_emblem_install_custom_emblem
at nautilus-emblem-utils.c line 235
#8 add_emblems_dialog_response_cb
at nautilus-emblem-view.c line 645
#9 g_cclosure_marshal_VOID__INT
at gmarshal.c line 216
#10 g_closure_invoke
at gclosure.c line 437
#11 signal_emit_unlocked_R
at gsignal.c line 2822
#12 g_signal_emit_valist
at gsignal.c line 2554
#13 g_signal_emit
at gsignal.c line 2612
#14 gtk_dialog_response
at gtkdialog.c line 826
#15 action_widget_activated
at gtkdialog.c line 533
#16 g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#17 g_closure_invoke
at gclosure.c line 437
#18 signal_emit_unlocked_R
at gsignal.c line 2822
#19 g_signal_emit_valist
at gsignal.c line 2554
#20 g_signal_emit
at gsignal.c line 2612
#21 gtk_button_clicked
at gtkbutton.c line 555
#22 gtk_real_button_released
at gtkbutton.c line 1044
#23 g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#24 g_type_class_meta_marshal
at gclosure.c line 514
#25 g_closure_invoke
at gclosure.c line 437
#26 signal_emit_unlocked_R
at gsignal.c line 2752
#27 g_signal_emit_valist
at gsignal.c line 2554
#28 g_signal_emit
at gsignal.c line 2612
#29 gtk_button_released
at gtkbutton.c line 547
#30 gtk_button_button_release
at gtkbutton.c line 960
#31 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 82
#32 g_type_class_meta_marshal
at gclosure.c line 514
#33 g_closure_invoke
at gclosure.c line 437
#34 signal_emit_unlocked_R
at gsignal.c line 2860
#35 g_signal_emit_valist
at gsignal.c line 2564
#36 g_signal_emit
at gsignal.c line 2612
#37 gtk_widget_event_internal
at gtkwidget.c line 3269
#38 gtk_propagate_event
at gtkmain.c line 2268
#39 gtk_main_do_event
at gtkmain.c line 1503
#40 gdk_event_dispatch
at gdkevents-x11.c line 2064
#41 g_main_dispatch
at gmain.c line 1751
#42 g_main_context_dispatch
at gmain.c line 2299
#43 g_main_context_iterate
at gmain.c line 2380
#44 g_main_loop_run
at gmain.c line 2600
#45 gtk_main
at gtkmain.c line 1093
#46 main
at nautilus-main.c line 280
#47 __libc_start_main
from /lib/libc.so.6
#0 wait4
from /lib/libc.so.6

Comment 1 mwehner 2003-09-27 18:43:31 UTC

I can reproduce this crash, but get a different stack:

Backtrace was generated from '/usr/bin/nautilus'

[New Thread 1089429376 (LWP 31739)]
[New Thread 1096362928 (LWP 31750)]
[New Thread 1096096688 (LWP 31749)]
[New Thread 1095830448 (LWP 31748)]
[New Thread 1095564208 (LWP 31747)]
[New Thread 1095297968 (LWP 31746)]
[New Thread 1093606320 (LWP 31743)]
[New Thread 1093340080 (LWP 31742)]
[New Thread 1093073840 (LWP 31741)]
[New Thread 1092807600 (LWP 31740)]
0xffffe410 in ?? ()

+ Trace 40484

Thread 1 (Thread 1089429376 (LWP 31739))

#0 ??
#1 <signal handler called>
#2 free
from /lib/tls/libc.so.6
#3 g_free
from /usr/lib/libglib-2.0.so.0
#4 destroy_emblem
at nautilus-emblem-view.c line 477
#5 g_slist_foreach
from /usr/lib/libglib-2.0.so.0
#6 destroy_emblem_list
at nautilus-emblem-view.c line 487
#7 g_datalist_clear
from /usr/lib/libglib-2.0.so.0
#8 g_object_class_list_properties
from /usr/lib/libgobject-2.0.so.0
#9 gtk_object_destroy
from /usr/lib/libgtk-x11-2.0.so.0
#10 gtk_widget_get_default_direction
from /usr/lib/libgtk-x11-2.0.so.0
#11 gtk_window_reshow_with_initial_size
from /usr/lib/libgtk-x11-2.0.so.0
#12 g_object_class_list_properties
from /usr/lib/libgobject-2.0.so.0
#13 g_signal_type_cclosure_new
from /usr/lib/libgobject-2.0.so.0
#14 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#15 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#16 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#17 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#18 gtk_button_clicked
from /usr/lib/libgtk-x11-2.0.so.0
#19 _gtk_button_paint
from /usr/lib/libgtk-x11-2.0.so.0
#20 _gtk_button_paint
from /usr/lib/libgtk-x11-2.0.so.0
#21 _gtk_marshal_BOOLEAN__BOXED
from /usr/lib/libgtk-x11-2.0.so.0
#22 g_cclosure_new_swap
from /usr/lib/libgobject-2.0.so.0
#23 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#24 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#25 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#26 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#27 gtk_widget_send_expose
from /usr/lib/libgtk-x11-2.0.so.0
#28 gtk_propagate_event
from /usr/lib/libgtk-x11-2.0.so.0
#29 gtk_main_do_event
from /usr/lib/libgtk-x11-2.0.so.0
#30 _gdk_events_queue
from /usr/lib/libgdk-x11-2.0.so.0
#31 unblock_source
from /usr/lib/libglib-2.0.so.0
#32 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#33 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#34 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#35 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#36 main
at nautilus-main.c line 282
#37 __libc_start_main
from /lib/tls/libc.so.6
#0 ??

Comment 2 Kjartan Maraas 2003-11-02 20:40:06 UTC

Confirmed with the latest fedora packages.

Comment 3 Kjartan Maraas 2003-11-02 20:41:32 UTC

Pasting backtrace since it's not exactly the same as the above:

Backtrace was generated from '/usr/bin/nautilus'

(no debugging symbols found)...Using host libthread_db library
"/lib/tls/libthread_db.so.1".
(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...
(no debugging symbols found)...(no debugging symbols found)...[Thread
debugging using libthread_db enabled]
[New Thread -1084663936 (LWP 4234)]
[New Thread -1088922704 (LWP 4578)]
[New Thread -1088107600 (LWP 4249)]
[New Thread -1087374416 (LWP 4246)]
[New Thread -1087108176 (LWP 4245)]

0x005b1c32 in _dl_sysinfo_int80 () from /lib/ld-linux.so.2

+ Trace 41394

Thread 1 (Thread -1084663936 (LWP 4234))

#0 _dl_sysinfo_int80
from /lib/ld-linux.so.2
#1 __waitpid_nocancel
from /lib/tls/libpthread.so.0
#2 libgnomeui_segv_handle
at gnome-ui-init.c line 738
#3 <signal handler called>
#4 nautilus_emblem_verify_keyword
from /usr/lib/libnautilus-private.so.2
#5 nautilus_emblem_install_custom_emblem
from /usr/lib/libnautilus-private.so.2
#6 nautilus_emblem_view_get_type
from /usr/lib/bonobo/libnautilus-emblem-view.so
#7 g_cclosure_marshal_VOID__INT
at gmarshal.c line 216
#8 g_closure_invoke
at gclosure.c line 437
#9 signal_emit_unlocked_R
at gsignal.c line 2822
#10 g_signal_emit_valist
at gsignal.c line 2554
#11 g_signal_emit
at gsignal.c line 2612
#12 gtk_dialog_response
at gtkdialog.c line 826
#13 action_widget_activated
at gtkdialog.c line 533
#14 g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#15 g_closure_invoke
at gclosure.c line 437
#16 signal_emit_unlocked_R
at gsignal.c line 2822
#17 g_signal_emit_valist
at gsignal.c line 2554
#18 g_signal_emit
at gsignal.c line 2612
#19 gtk_button_clicked
at gtkbutton.c line 555
#20 gtk_button_finish_activate
at gtkbutton.c line 1103
#21 gtk_button_key_release
at gtkbutton.c line 974
#22 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 82
#23 g_type_class_meta_marshal
at gclosure.c line 514
#24 g_closure_invoke
at gclosure.c line 437
#25 signal_emit_unlocked_R
at gsignal.c line 2860
#26 g_signal_emit_valist
at gsignal.c line 2564
#27 g_signal_emit
at gsignal.c line 2612
#28 gtk_widget_event_internal
at gtkwidget.c line 3269
#29 gtk_propagate_event
at gtkmain.c line 2228
#30 gtk_main_do_event
at gtkmain.c line 1503
#31 gdk_event_dispatch
at gdkevents-x11.c line 2064
#32 g_main_dispatch
at gmain.c line 1751
#33 g_main_context_dispatch
at gmain.c line 2299
#34 g_main_context_iterate
at gmain.c line 2380
#35 g_main_loop_run
at gmain.c line 2600
#36 gtk_main
at gtkmain.c line 1093
#37 main
#0 _dl_sysinfo_int80
from /lib/ld-linux.so.2

Comment 4 Kiran Kumar Immidi 2003-11-10 09:28:02 UTC

Created attachment 21325 [details] [review]
Patch to fix this problem

Comment 5 Kiran Kumar Immidi 2003-11-10 09:35:33 UTC

In function nautilus_emblem_view_drag_received_cb() of
nautilus/components/emblem/nautilus-emblem-view.c, the keyword field
of the Emblem structure was not being set to NULL. The patch does this
in each case of the switch block.

Comment 6 Luis Villa 2003-11-10 19:59:48 UTC

Kiran: cool. Feel free to add the 'PATCH' keyword; I've given you
permissions to make modificatoins to bugs.

Comment 7 Martin Wehner 2004-03-22 08:34:32 UTC

*** Bug 137869 has been marked as a duplicate of this bug. ***