After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 122265 - Crash when trying to access non-existing vfs-url
Crash when trying to access non-existing vfs-url
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other other
: High critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 114392 118753 122382 122421 124968 127372 127910 128568 128578 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-09-14 10:30 UTC by michiel
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description michiel 2003-09-14 10:30:49 UTC 
Distribution: Unknown
Package: nautilus
Severity: normal
Version: GNOME2.4.0 2.4.0
Gnome-Distributor: GNOME.Org
Synopsis: Crash when trying to access non-existing vfs-url
Bugzilla-Product: nautilus
Bugzilla-Component: general
Bugzilla-Version: 2.4.0
BugBuddy-GnomeVersion: 2.0 (2.4.0.1)
Description:
Description of the crash:
Crash when trying to access non-existing vfs-url

Steps to reproduce the crash:
1. Access smb:// or blaat:// or meh:// or foo://

Expected Results:
Some error message, but not a crash.

How often does this happen?
Always

Additional Information:
I don't have gnome-vfs-extras installed, only gnome-vfs


Debugging Information:

Backtrace was generated from '/usr/bin/nautilus'

[New Thread 16384 (LWP 18308)]
[New Thread 32769 (LWP 18309)]
[New Thread 16386 (LWP 18310)]
[New Thread 32771 (LWP 18311)]
[New Thread 49156 (LWP 18314)]
[New Thread 65541 (LWP 18315)]
0x40b70bb9 in __wait4 () at __wait4:-1
	in __wait4

+ Trace 40170

Thread 1 (Thread 16384 (LWP 18308))

  • #0 __wait4
  • #1 __DTOR_END__
    from /lib/libc.so.6
  • #2 waitpid
    at wrapsyscall.c line 181
  • #3 libgnomeui_segv_handle
    at gnome-ui-init.c line 738
  • #4 __pthread_sighandler
    at sighandler.c line 38
  • #5 <signal handler called>
  • #6 __kill
  • #7 pthread_kill
    at signals.c line 65
  • #8 raise
    at signals.c line 181
  • #9 *__GI_abort
    at ../sysdeps/generic/abort.c line 88
  • #10 g_logv
  • #11 g_log
  • #12 nautilus_file_get_internal
    at nautilus-file.c line 361
  • #13 nautilus_file_get_existing
    at nautilus-file.c line 397
  • #14 nautilus_directory_get_existing_corresponding_file
    at nautilus-directory.c line 454
  • #15 nautilus_directory_invalidate_count_and_mime_list
    at nautilus-directory-async.c line 2128
  • #16 nautilus_directory_force_reload_internal
    at nautilus-directory-async.c line 2167
  • #17 vfs_force_reload
    at nautilus-vfs-directory.c line 132
  • #18 nautilus_directory_force_reload
    at nautilus-directory.c line 1595
  • #19 begin_location_change
    at nautilus-window-manage-views.c line 1539
  • #20 open_location
    at nautilus-window-manage-views.c line 769
  • #21 nautilus_window_open_location
    at nautilus-window-manage-views.c line 777
  • #22 nautilus_window_go_to
    at nautilus-window.c line 361
  • #23 navigation_bar_location_changed_callback
    at nautilus-window.c line 396
  • #24 g_cclosure_marshal_VOID__STRING
    at gmarshal.c line 496
  • #25 g_closure_invoke
    at gclosure.c line 437
  • #26 signal_emit_unlocked_R
    at gsignal.c line 2822
  • #27 g_signal_emit_valist
    at gsignal.c line 2554
  • #28 g_signal_emit
    at gsignal.c line 2612
  • #29 nautilus_navigation_bar_location_changed
    at nautilus-navigation-bar.c line 148
  • #30 g_cclosure_marshal_VOID__STRING
    at gmarshal.c line 496
  • #31 g_closure_invoke
    at gclosure.c line 437
  • #32 signal_emit_unlocked_R
    at gsignal.c line 2822
  • #33 g_signal_emit_valist
    at gsignal.c line 2554
  • #34 g_signal_emit
    at gsignal.c line 2612
  • #35 nautilus_navigation_bar_location_changed
    at nautilus-navigation-bar.c line 148
  • #36 g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77
  • #37 g_closure_invoke
    at gclosure.c line 437
  • #38 signal_emit_unlocked_R
    at gsignal.c line 2822
  • #39 g_signal_emitv
    at gsignal.c line 2461
  • #40 gtk_binding_entry_activate
    at gtkbindings.c line 524
  • #41 binding_match_activate
    at gtkbindings.c line 926
  • #42 gtk_bindings_activate_list
    at gtkbindings.c line 1062
  • #43 _gtk_bindings_activate_event
    at gtkbindings.c line 1137
  • #44 gtk_widget_real_key_press_event
    at gtkwidget.c line 3013
  • #45 gtk_entry_key_press
    at gtkentry.c line 1567
  • #46 nautilus_entry_key_press
    at nautilus-entry.c line 143
  • #47 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 82
  • #48 g_type_class_meta_marshal
    at gclosure.c line 514
  • #49 g_closure_invoke
    at gclosure.c line 437
  • #50 signal_emit_unlocked_R
    at gsignal.c line 2860
  • #51 g_signal_emit_valist
    at gsignal.c line 2564
  • #52 g_signal_emit
    at gsignal.c line 2612
  • #53 gtk_widget_event_internal
    at gtkwidget.c line 3269
  • #54 gtk_widget_event
    at gtkwidget.c line 3075
  • #55 gtk_window_key_press_event
    at gtkwindow.c line 4070
  • #56 bonobo_window_key_press_event
    at bonobo-window.c line 267
  • #57 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 82
  • #58 g_type_class_meta_marshal
    at gclosure.c line 514
  • #59 g_closure_invoke
    at gclosure.c line 437
  • #60 signal_emit_unlocked_R
    at gsignal.c line 2860
  • #61 g_signal_emit_valist
    at gsignal.c line 2564
  • #62 g_signal_emit
    at gsignal.c line 2612
  • #63 gtk_widget_event_internal
    at gtkwidget.c line 3269
  • #64 gtk_widget_event
    at gtkwidget.c line 3075
  • #65 gtk_propagate_event
    at gtkmain.c line 2236
  • #66 gtk_main_do_event
    at gtkmain.c line 1503
  • #67 gdk_event_dispatch
    at gdkevents-x11.c line 2064
  • #68 g_main_dispatch
    at gmain.c line 1751
  • #69 g_main_context_dispatch
    at gmain.c line 2299
  • #70 g_main_context_iterate
    at gmain.c line 2380
  • #71 g_main_loop_run
    at gmain.c line 2600
  • #72 gtk_main
    at gtkmain.c line 1093
  • #73 main
    at nautilus-main.c line 280
  • #74 __libc_start_main
    at ../sysdeps/generic/libc-start.c line 144 




------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-09-14 06:30 -------

Unknown version 2.4.0 in product nautilus. Setting version to the default, "unspecified".
The original reporter (michiel@sikkes.xs4all.nl) of this bug does not have an account here.
Reassigning to the exporter, unknown@bugzilla.gnome.org.
Reassigning to the default owner of the component, nautilus-maint@bugzilla.gnome.org.
Comment 1 Manuel Menal 2003-09-14 15:03:00 UTC 
Well, it does not really crash, it does a g_assert_not_reached (),
which will abort () - but yeah, it does not really matter from a user
point of view. :-)

As far as I can see, the patch for it is very, very simple ; I didn't
test it thoroughly - but as far as I can see, every function which
calls nautilus_file_get(_existing) () tests whether the return value
is NULL or not, so this shouldn't cause any trouble. So, here is it :


diff -Nurp nautilus.old/libnautilus-private/nautilus-file.c
nautilus/libnautilus-private/nautilus-file.c
--- nautilus.old/libnautilus-private/nautilus-file.c    2003-09-14
16:16:52.000000000 +0200
+++ nautilus/libnautilus-private/nautilus-file.c        2003-09-14
16:18:35.000000000 +0200
@@ -358,7 +358,7 @@ nautilus_file_get_internal (const char *
                        }
                        relative_uri = strdup (relative_uri_tmp);
                } else {
-                       g_assert_not_reached ();
+                       return NULL;
                }
        }
 
You can find it at http://mmenal.nerim.net/nautilus.vfs.patch - it
seems that the copy/paste'd patch won't apply because of TAB -> spaces
conversion and such.
Comment 2 Kjartan Maraas 2003-09-16 20:25:26 UTC 
I can confirm this with 2.4.0 here on the current RH beta
Comment 3 Kjartan Maraas 2003-09-16 20:37:15 UTC 
*** Bug 122421 has been marked as a duplicate of this bug. ***
Comment 4 Kjartan Maraas 2003-09-16 20:48:40 UTC 
*** Bug 122382 has been marked as a duplicate of this bug. ***
Comment 5 Alexander Larsson 2003-09-19 08:31:30 UTC 
Fixed in cvs.
Comment 6 mwehner 2003-09-26 09:48:59 UTC 
*** Bug 114392 has been marked as a duplicate of this bug. ***
Comment 7 Narayana Pattipati 2003-10-23 08:39:56 UTC 
*** Bug 118753 has been marked as a duplicate of this bug. ***
Comment 8 Martin Wehner 2003-11-26 07:01:44 UTC 
*** Bug 127910 has been marked as a duplicate of this bug. ***
Comment 9 Martin Wehner 2003-11-26 07:02:49 UTC 
*** Bug 127372 has been marked as a duplicate of this bug. ***
Comment 10 Martin Wehner 2003-11-27 14:52:16 UTC 
*** Bug 124968 has been marked as a duplicate of this bug. ***
Comment 11 Matthew Gatto 2003-12-05 17:45:58 UTC 
*** Bug 128578 has been marked as a duplicate of this bug. ***
Comment 12 Martin Wehner 2003-12-23 17:43:30 UTC 
*** Bug 128568 has been marked as a duplicate of this bug. ***