After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 121182 - register enum GTypes
register enum GTypes
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Other
cvs (head)
Other Linux
: Normal normal
: 2.6
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on: 121386
Blocks:
 
 
Reported: 2003-09-01 14:26 UTC by Murray Cumming
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnomevfs_enum_types.patch (7.18 KB, patch)
2003-09-01 14:27 UTC, Murray Cumming 		none Details | Review
gnomevfs_enum_types2.patch (8.13 KB, patch)
2003-09-04 11:35 UTC, Murray Cumming 		none Details | Review
gnomevfs_enum_types3.patch (7.79 KB, patch)
2003-10-01 13:34 UTC, Murray Cumming 		none Details | Review
gnomevfs_enum_types4.patch (9.72 KB, patch)
2003-11-09 15:04 UTC, Murray Cumming 		none Details | Review

Description Murray Cumming 2003-09-01 14:26:08 UTC 
This patch adds the get_type() functions to register GTypes for the enums,
as other GNOME libraries do. We need this for gtkmm, and I think it's
necessary for use in GValues.
Comment 1 Murray Cumming 2003-09-01 14:27:02 UTC 
Created attachment 19643 [details] [review]
gnomevfs_enum_types.patch
Comment 2 Murray Cumming 2003-09-01 14:29:18 UTC 
This isn't actually 100% finished, because one of the function names
has the _ in the wrong place, because glib-mkenums is confused by the
capitalization of GnomeVFSURIHideOptions. But I wanted to upload this
somewhere safe.
Comment 3 Murray Cumming 2003-09-04 11:34:46 UTC 
Here (gnomevfs_enum_types2.patch) is a full working patch, but it
requires the glib patch in bug #121386.
Comment 4 Murray Cumming 2003-09-04 11:35:27 UTC 
Created attachment 19723 [details] [review]
gnomevfs_enum_types2.patch
Comment 5 Alexander Larsson 2003-09-18 09:46:21 UTC 
Hmm. That's in glib 2.4, right?
I guess we can use that for 2.5 though since we're depending on the
new gtk+.
Comment 6 Murray Cumming 2003-09-18 09:51:41 UTC 
Yes, it will need GTK+ 2.4.
Comment 7 Murray Cumming 2003-09-18 09:52:20 UTC 
I mean glib 2.4.
Comment 8 Murray Cumming 2003-10-01 13:33:25 UTC 
This patch (gnomevfs_enum_types3.patch) is better - it uses the
GNOME_VFS_ macro prefix instead of LIBGNOMEVFS_
Comment 9 Murray Cumming 2003-10-01 13:34:41 UTC 
Created attachment 20408 [details] [review]
gnomevfs_enum_types3.patch
Comment 10 Murray Cumming 2003-11-09 15:04:21 UTC 
Created attachment 21317 [details] [review]
gnomevfs_enum_types4.patch
Comment 11 Murray Cumming 2003-11-09 15:05:12 UTC 
This one (gnomevfs_enum_types4.patch) doesn't require the glib patch.
May I commit this to HEAD?
Comment 12 Murray Cumming 2003-11-27 14:15:50 UTC 
Please.
Comment 13 Alexander Larsson 2003-11-27 14:30:07 UTC 
looks fine to commit.
Comment 14 Murray Cumming 2003-11-29 16:07:00 UTC 
Applied.