After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 121165 - Compilation errors due to invalid -Wall option
Compilation errors due to invalid -Wall option
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.3
Other opensolaris
: Normal normal
: 0.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-09-01 11:35 UTC by Damien Carbery
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
config.log in tar.gz file (18.32 KB, application/octet-stream)
2003-09-03 09:47 UTC, Damien Carbery 		  Details
patch to add AS_COMPILER_FLAG() (1.07 KB, patch)
2003-09-03 17:32 UTC, David Schleef 		none Details | Review

Description Damien Carbery 2003-09-01 11:35:31 UTC 
The Sun ONE Studio 8 compiler does not support the '-Wall' option and
results in a compilation error.

Makefile and compiler output:
cc -DHAVE_CONFIG_H -I. -I. -I../../.. -I/opt/gnome-2.4/include
-I../../../gst-libs -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -mt
-I/opt/gnome-2.4/include/gstreamer-0.6 -I/opt/gnome-2.4/include/glib-2.0
-I/opt/gnome-2.4/lib/glib-2.0/include -I/opt/gnome-2.4/include/libxml2
-DGST_DISABLE_DEPRECATED -g -Wall -finline-functions -ffast-math -g
-I/opt/gnome-2.4/include -c audio.c  -KPIC -DPIC -o libgstaudio_la-audio.o
cc: illegal option -Wall
make[4]: *** [libgstaudio_la-audio.lo] Error 1
make[4]: Leaving directory
`/gnome/2.4/nightly/src-2.4-20030901/gst-plugins-0.6.3/gst-libs/gst/audio'

This option is used in other makefiles in the gst-libs/gst directory tree.
Patching 'configure' fixes this (remove -Wall from GST_ERROR on line 1758
and 1764).
Comment 1 David Schleef 2003-09-03 03:37:57 UTC 
Please attach your config.log.
Comment 2 Ronald Bultje 2003-09-03 06:09:10 UTC 
We need to use AS_COMPILER_FLAG() here, like we do in HEAD:

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gstreamer/configure.ac.diff?r1=1.205.2.2.2.18&r2=1.205.2.2.2.19
Comment 3 Damien Carbery 2003-09-03 09:47:45 UTC 
Created attachment 19691 [details]
config.log in tar.gz file
Comment 4 David Schleef 2003-09-03 17:31:27 UTC 
Ah, yes, of course.  I thought it already used AS_COMPILER_FLAG().
Comment 5 David Schleef 2003-09-03 17:32:13 UTC 
Created attachment 19706 [details] [review]
patch to add AS_COMPILER_FLAG()
Comment 6 David Schleef 2003-09-04 23:01:19 UTC 
Committed to 0.6 CVS.