GNOME Bugzilla – Bug 120784
shapes have black outlines
Last modified: 2019-03-20 11:08:21 UTC
I have created diagrams and exported them as shapes. When I use the shape, all objects now have black outlines. This is not the way the shape was created. You can easily see this behavior by creating a square and changing the outline and fill color to something other than black and white. Save this as a shape. When you use the shape, you will see that the outline is oulined in black. This does not seem to occur when I change the line width from the default of .10 to 1.0.
this is a known glitch, or at least I have encountered it many times, and I am fairly sure I discussed it onlist. to workaround this you basically have to provide an outline in the same colour as the shape fill and then edit the shape file to make sure the outline is thick enough to cover the thin black line. help tracking down where exactly in the code this occurs would be very helpful.
Looking at the code objects/custom/custom_object.c(custom_create) this is intended behaviour : custom->border_width = attributes_get_default_linewidth(); custom->border_color = attributes_get_foreground(); custom->inner_color = attributes_get_background(); and I'm pretty sure there would be people complaining if they would not be able to produce custom objects with default attributes anymore. For example look at the whole "Assorted" sheet which makes extensive use of "inheriting" default toolbox properties. If at all changing this would have to be done by a shape exporter option and maybe even by extending the shape dialect. IMO the behaviour just needs to be documented.
*** Bug 124411 has been marked as a duplicate of this bug. ***
I went to great lengths with the Assorted sheet to block out the thin black lines that were occuring. basically as the poster suggested you make the line colour thicker so that it completely overlays the bothersome black lines. I need to look at this further (and read the code) but Hans I dont understand how why the thin black lines are desirable behaviour or something we have to put up with to allow inherited colours? (give me a few days to try and figure it out for myself though if it is really obvious)
There's no reason to have colors in the shape file if they are overridden anyway. The shapes that want to use the default colors ought to have a way to indicate that (and that should be the default for new shapes). The current system appears to allow stating a color that is then overridden, which is problematic. While most objects would either use all default colors or all designated colors, I could imagine some that would combine the two. Those would have to be hand-modified, though, so an export option may be a good way to go.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/dia/issues/90.