GNOME Bugzilla – Bug 120150
at-spi bonobo service i18n commented out
Last modified: 2004-12-22 21:47:04 UTC
at-spi is not properly internationalized due to critical lines being commented out in its configure.in: dnl internationalization support dnl ALL_LINGUAS="az be ca cs cy da de el eo es et fi fr he hi it ko mn ms nl pl pt_BR pt ru sk sq sr@Latn sr sv vi zh_CN" dnl AM_GLIB_GNU_GETTEXT It is important that this package, part of GNOME's core, it properly i18nised for the GNOME2.4 release.
It seems it was removed by this commit by baddog@cvs.gnome.org: http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvs/gnome&subdir=at-spi&command=DIFF_FRAMESET&file=configure.in&rev2=1.21&rev1=1.20
well, there are only two translatable strings in all of at-spi AFAIK, both in the Accessibility_Registry.server.in.in file. Fairly obscure strings, even at that. Severity is not major IMO - but if someone wants to make sure the po directories are building OK then I see no harm in reinstating the dnl lines. I don't know why they were removed, presumably a build breakage.
The commit comment seems to have been: --- 1.21 <baddog> 2001-12-07 13:44 Comment out extraneous i18n support temporarily --- Perhaps the reverting of this just accidentally forgotten. There are 4 messages in at-spi (see http://developer.gnome.org/projects/gtp/status/gnome-2.4/PO/at-spi.HEAD.pot), and none of them seem extremely important, but this should still probably be fixed before the release.
It was me who did it; at that time there was a build breakage, and no translation was present at all, so I commented it out. For now, it would probably be good to reenable it again -- or not. I saw no *textdomain calls in source, is it useful at all to reenable the i18n support in configure.in? If i18n of at-spi is desired, then probably more have to be done.
If you have time to fix this for GNOME 2.4 so that the translations work, then IMHO please do.
adding accessibility keyword
at-spi doesn't emit end-user strings (as a rule). But the .server.in i18n probably ought to be done.
Bill, If that's the case here, I'd suggest the following action: - move bridge.c to POTFILES.skip instead of POTFILES.in (so "intltool-update -m" won't report 'missing' files), or unmark any strings marked there (for the same reason) -- no need to translate strings which don't get used - mark this as resolved If these two strings in bridge.c (g_warning and a g_print) are actually translated somehow, you may mark this as NOTABUG, and add comment to configure.in that translators need not update ALL_LINGUAS. intltool merges translations into .server files without paying attention to ALL_LINGUAS (it uses all *.po files in po subdirectory), so they're already merged correctly.
Danilo I took your advice and added POTFILES.skip. I also added a comment to the dnl line, and am closing this bug as NOTABUG. Thanks!