GNOME Bugzilla – Bug 120065
Support playing and stopping in gst-launch via signals.
Last modified: 2004-12-22 21:47:04 UTC
gst-launch is useful for debugging elements. Thus it does make sense to have functionality that allows one to play and stop the pipeline. In this way the developer of a plugin can test the behaviour of an element under state change.
Created attachment 19285 [details] Proposed gst-launch.
The attached source implements the following behaviour: - SIGUSR1 changes state to PLAYING. - SIGUSR2 changes state to NULL. Others could be added, but these are IHMO the most important for testing.
Isn't gst-launch-gui (from the gst-editor package) much more useful for this? It provides the same functionality as gst-launch, but in a UI (Gnome-2 based), including stop/pause/play buttons... Or gst-editor itself... It provides support for quite some features. Isn't it a bit overkill to add this to gst-launch?
The most important advantadge for me of gst-launch is that, since the code is simpler, it is better for debugging with gdb. With this patch, I can put a breakpoing with gdb in play_handler, follow it and learn why the request is not working.
Hm, ok, I see... Sounds interesting. :). Could you add a diff -u patch against CVS?
Created attachment 19320 [details] Diff against CVS.
Created attachment 19337 [details] [review] Updated diff
The above patch: 1) Fixes compilation with -Werror turned on for your patch 2) Moves over if/else if/else loops to switch/case 3) Adapts coding style to our default This looks fine to apply to me. :).
Applied. Thanks for the idea. :).
This patch is incomplete. The man page needs to be updated to reflect these new capabilities. Please reopen until this is done.
Doh! I should have waited for the CVS log to come through. I see docs were updated. Nevermind last comment.