After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119982 - commas at end of enumerator list
commas at end of enumerator list
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: general
2.2.1
Other All
: Normal normal
: ---
Assigned To: Chema Celorio
Chema Celorio
: 118850 122191 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-08-15 21:33 UTC by Matt Kraai
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matt Kraai 2003-08-15 21:33:58 UTC 
Abiword fails to compile because gnome-print-dialog.h contains
commas at the end of enumerator lists, which is not valid C++.
Comment 1 Matt Kraai 2003-08-15 21:37:38 UTC 
I can't attach the patch, so I've pasted it below.  Sorry.

--- libgnomeprintui-2.2.1.3.orig/libgnomeprintui/gnome-print-dialog.h
2003-08-15 13:33:38.000000000 -0700
+++ libgnomeprintui-2.2.1.3/libgnomeprintui/gnome-print-dialog.h
2003-08-15 13:40:12.000000000 -0700
@@ -65,7 +65,7 @@
 	GNOME_PRINT_RANGE_ALL = (1 << 1),
 	GNOME_PRINT_RANGE_RANGE = (1 << 2),
 	GNOME_PRINT_RANGE_SELECTION = (1 << 3),
-	GNOME_PRINT_RANGE_SELECTION_UNSENSITIVE  = (1 << 4),
+	GNOME_PRINT_RANGE_SELECTION_UNSENSITIVE  = (1 << 4)
 };
 
 /*
@@ -83,7 +83,7 @@
 enum GnomePrintButtons {
 	GNOME_PRINT_DIALOG_RESPONSE_PRINT = 1,
 	GNOME_PRINT_DIALOG_RESPONSE_PREVIEW,
-	GNOME_PRINT_DIALOG_RESPONSE_CANCEL = GTK_RESPONSE_CANCEL,
+	GNOME_PRINT_DIALOG_RESPONSE_CANCEL = GTK_RESPONSE_CANCEL
 };
 
 GType gnome_print_dialog_get_type (void);
Comment 2 Murray Cumming 2003-09-14 10:22:24 UTC 
*** Bug 122191 has been marked as a duplicate of this bug. ***
Comment 3 Murray Cumming 2003-09-14 10:22:48 UTC 
*** Bug 118850 has been marked as a duplicate of this bug. ***
Comment 4 Chema Celorio 2003-09-19 14:03:06 UTC 
Murray, 

feel free to commit.
Comment 5 Murray Cumming 2003-09-28 16:50:53 UTC 
This seems to have been fixed already, by Jeremy Katz. I checked both
branches.