After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119762 - gnome-vfs schemas files need to be intltoolized
gnome-vfs schemas files need to be intltoolized
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Other
cvs (head)
Other All
: Normal normal
: 2.6
Assigned To: Malcolm Tredinnick
Malcolm Tredinnick
Depends on:
Blocks:
 
 
Reported: 2003-08-13 08:22 UTC by Christian Rose
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch. (18.84 KB, patch)
2003-09-21 07:24 UTC, Christian Neumair
none Details | Review
Proposed patch, incorporating teuf's comment (18.49 KB, patch)
2003-09-21 11:41 UTC, Christian Neumair
none Details | Review

Description Christian Rose 2003-08-13 08:22:26 UTC
It seems there are several schemas files in gnome-vfs:

schemas/desktop_default_applications.schemas  schemas/system_http_proxy.schemas

These files are not properly "intltoolized"; i.e. they also need to at
least be renamed to *.schemas.in and mentioned in po/POTFILES.in for
intltool-extract to pick them up, and for the translators to actually get
their messages to translate in the pot and po files.

Perhaps there are also other steps that I'm missing in order to make this
work; I'm not really experienced with intltoolizing things.
Comment 1 Christian Rose 2003-08-13 08:24:10 UTC
Please also note that adding these for 2.4 will break string freeze,
so asking for permission is needed if this is going to be fixed for 2.4.
Comment 2 Christophe Fergeau 2003-08-13 08:49:50 UTC
I feel this can wait until 2.6, does anyone disagree?
Comment 3 Christian Rose 2003-08-13 09:48:51 UTC
I agree.
Comment 4 Malcolm Tredinnick 2003-08-14 12:02:18 UTC
Why wait until 2.6, rather than 2.4.1? We can at least add the
infrastructure. The worst is does is degrade a couple of i18n
statistics; hardly the end of the world.

In any case, I'll take this bug. I know what needs to be done here.
Obviously nothing's going to happen for a few weeks.
Comment 5 Christophe Fergeau 2003-08-14 12:41:56 UTC
Because I have no idea what happens between 2.4.0 and 2.4.1, ie if the
various freeze are lifted and so on. The only thing I'm sure is that
there won't be any freeze when 2.5 starts, so nobody will complain if
this is fixed in 2.5. But this 2.6 milestone is really to be taken as
"post 2.4.0"
Comment 6 Christophe Fergeau 2003-08-14 12:43:02 UTC
Please cc the maintainers when you take a bug, otherwise nobody will
know what happens on the bug apart from you :)
Comment 7 Abel Cheung 2003-08-18 18:05:14 UTC
The .schemas -> .schemas.in can be done right now. If string breakage
is to be avoided, just refrain from adding them to POTFILES.in -- that
would be enough.
Comment 8 Alexander Larsson 2003-09-18 09:43:03 UTC
We should do this on HEAD now.
Comment 9 Christian Neumair 2003-09-21 07:24:15 UTC
Created attachment 20154 [details] [review]
Proposed patch.
Comment 10 Christophe Fergeau 2003-09-21 10:25:03 UTC
I'm not really good at the auto* stuff, but shouldn't
$(schema_in_files) be added to EXTRA_DIST and $(schema_DATA) to
CLEANFILES ?
Apart from that, the patch looks good (assuming you tested it compiles
properly), thanks for it :)
Comment 11 Christian Neumair 2003-09-21 11:36:20 UTC
Christophe: You are completely right! Thanks for pointing this out!

regs,
 Chris
Comment 12 Christian Neumair 2003-09-21 11:41:02 UTC
Created attachment 20163 [details] [review]
Proposed patch, incorporating teuf's comment
Comment 13 Alexander Larsson 2003-09-22 08:18:17 UTC
Does this actually work? The schema_in_files lists the .schemas files,
not the .schemas.in files.
Comment 14 Alexander Larsson 2003-09-22 08:40:17 UTC
Checked in.