After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119510 - GstPluginFeature->rank isn't dumped to XML
GstPluginFeature->rank isn't dumped to XML
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 0.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-08-09 21:32 UTC by Ronald Bultje
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.25 KB, patch)
2003-08-18 06:35 UTC, David Schleef 		none Details | Review

Description Ronald Bultje 2003-08-09 21:32:45 UTC 
Both GstPluginFeature as well as GstElementFactory (a child of
PluginFeature) have a rank entry in their struct. They seem to do the same,
so one needs to be removed.
Comment 1 David Schleef 2003-08-18 06:34:16 UTC 
Does GstPluginFeature need a rank?

Anyway, here's a patch to convert to using the rank in
GstPluginFeature instead of GstElementFactory.
Comment 2 David Schleef 2003-08-18 06:35:39 UTC 
Created attachment 19300 [details] [review]
patch
Comment 3 Ronald Bultje 2003-08-18 09:25:50 UTC 
You use factory.feature->rank in some places, shouldn't that be
GST_PLUGIN_FEATURE (factory)->rank?

Apart from that, it sounds ok. Let's apply it. :).
Comment 4 David Schleef 2003-08-18 18:38:02 UTC 
Yes, it should be GST_PLUGIN_FEATURE().  Brain fart.
Comment 5 Ronald Bultje 2003-08-18 21:16:03 UTC 
Applied with GST_PLUGIN_FEATURE (). According to Dave, the
pluginfeature doesn't dump to XML, so I'm leaving this open with a new
subject.
Comment 6 David Schleef 2003-08-21 05:46:13 UTC 
Not only does it dump the rank to XML correctly, it also loads it
correctly.  I don't entirely understand why, but I'll accept it.  I'll
also check in the addition to gst-inspect that shows the rank of the
plugin feature.