GNOME Bugzilla – Bug 119510
GstPluginFeature->rank isn't dumped to XML
Last modified: 2004-12-22 21:47:04 UTC
Both GstPluginFeature as well as GstElementFactory (a child of PluginFeature) have a rank entry in their struct. They seem to do the same, so one needs to be removed.
Does GstPluginFeature need a rank? Anyway, here's a patch to convert to using the rank in GstPluginFeature instead of GstElementFactory.
Created attachment 19300 [details] [review] patch
You use factory.feature->rank in some places, shouldn't that be GST_PLUGIN_FEATURE (factory)->rank? Apart from that, it sounds ok. Let's apply it. :).
Yes, it should be GST_PLUGIN_FEATURE(). Brain fart.
Applied with GST_PLUGIN_FEATURE (). According to Dave, the pluginfeature doesn't dump to XML, so I'm leaving this open with a new subject.
Not only does it dump the rank to XML correctly, it also loads it correctly. I don't entirely understand why, but I'll accept it. I'll also check in the addition to gst-inspect that shows the rank of the plugin feature.