After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 119125 - shift+insert should paste clipboard, not selection primary
shift+insert should paste clipboard, not selection primary
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
AP4
Depends on:
Blocks:
 
 
Reported: 2003-08-04 20:11 UTC by Noah Levitt
Modified: 2006-02-11 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch I've been using for a while (887 bytes, patch)
2004-02-19 19:50 UTC, Noah Levitt
none Details | Review

Description Noah Levitt 2003-08-04 20:11:55 UTC
In my opinion, consistency with other gnome applications is more important
than consistency with xterm, so shift+insert should paste the X clipboard
selction. Along the same lines, I think ctrl+insert should copy the
selection to the clipboard.
Comment 1 Calum Benson 2003-08-07 16:05:05 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 2 Nalin Dahyabhai 2003-08-11 16:02:16 UTC
Personally I disagree, but as both the paste_primary and
paste_clipboard methods are exposed by libvte, this can be decided at
the level of gnome-terminal's existing keybindings framework. 
Reassigning.
Comment 3 Mariano Suárez-Alvarez 2003-10-09 05:25:46 UTC
Copy and pasting originated from explicit user actions (control+c,
control+v, shift+insert, control+insert, and so on) are to use the
clipboard, as specified (well, sort of) in
http://pdx.freedesktop.org/Standards/clipboards-spec/clipboards.txt

Now, I can't do it from gnome-terminal, because the Shift+Insert
keyboard combination is actually handled by vte in
vte_terminal_key_press: 

...
case GDK_KP_Insert:
case GDK_Insert:
	if (terminal->pvt->modifiers & GDK_SHIFT_MASK) {
		vte_terminal_paste(terminal,GDK_SELECTION_PRIMARY);
		handled = TRUE;
		suppress_meta_esc = TRUE;
	}
	break;
...

So that vte actually does hard-code using the primary selection on
shift+insert. 

For some reason, now, if I do a Control+Insert while having something
selected and running bash, say, what I see is that the highlighed text
gets put into the primary X selection *and* the string "^G;5~" gets
fed to bash (here ^G is, of course, the ASCII bell) Ymmv, as someone
on IRC got just "5~" (maybe with the bell, he had sound off, apparently)
Comment 4 Mariano Suárez-Alvarez 2003-11-12 04:31:56 UTC
I'll move this to vte, which is where the fix should start...
Comment 5 Calum Benson 2004-01-23 17:13:24 UTC
Updating status whiteboard to reflect a11y team's assessment of priority.
Comment 6 Noah Levitt 2004-02-19 19:48:13 UTC
A symptom of this bug is that there is an inconsistency in the popup
menu in gnome-terminal. It has these two menu items:

   Copy    Ctrl+Insert
   Paste   Shift+Insert

But the menu items and the keystrokes do different things currently. 

P.S. Should this be assigned back to Nalin?
Comment 7 Noah Levitt 2004-02-19 19:50:43 UTC
Created attachment 24580 [details] [review]
patch I've been using for a while
Comment 8 Mariano Suárez-Alvarez 2004-06-28 05:24:04 UTC
(Noah, the popup has not shown the keyboard shortcuts for a while, and those are
not the default shortcuts anyways ;-) )

Nalin, adding Ctrl-Insert sounds reasonable. 

Also, if you do not like using CLIPBOARD instead of PRIMARY here, maybe this
could be parametrized? Everything in GTK seems to be using CLIPBOARD all over
for this, though...
Comment 9 Kjartan Maraas 2004-10-18 09:42:29 UTC
Any news on this issue?
Comment 10 Behdad Esfahbod 2006-02-11 18:35:34 UTC
I've already FIXED this.