After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 118890 - "Color background" should perhaps be "Background color" in gnome-applets
"Color background" should perhaps be "Background color" in gnome-applets
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: mini-commander
git master
Other All
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-08-01 16:16 UTC by Christian Rose
Modified: 2005-08-15 01:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixes this bug. (3.82 KB, patch)
2003-11-25 10:59 UTC, Kaushal Kumar
none Details | Review

Description Christian Rose 2003-08-01 16:16:08 UTC
#: mini-commander/src/mini-commander.schemas.in.h:2
msgid "Color background blue component"

#: mini-commander/src/mini-commander.schemas.in.h:3
msgid "Color background green component"

#: mini-commander/src/mini-commander.schemas.in.h:4
msgid "Color background red component"

#: mini-commander/src/mini-commander.schemas.in.h:5
msgid "Color foreground blue component"

#: mini-commander/src/mini-commander.schemas.in.h:6
msgid "Color foreground green component"

#: mini-commander/src/mini-commander.schemas.in.h:7
msgid "Color foreground red component"


"Color background" seems very weird. Shouldn't it be "background color" in
proper English? The same is applicable to "color foreground".

Perhaps these messages should be rewritten to something like:

"Green foreground color component"

etc.
Comment 1 Kevin Vandersloot 2003-08-16 19:20:26 UTC
How about "Green component of foreground color"? I agree that the 
current text is poor.
Comment 2 Christian Rose 2003-08-16 19:43:06 UTC
Excellent. Note that changing this now would break string freeze.
Comment 3 Kjartan Maraas 2003-10-26 16:40:14 UTC
These should go into 2.5.x
Comment 4 Kaushal Kumar 2003-11-21 04:28:09 UTC
Currently, the definitions in short and long are as follows:
<short>Color foreground green component</short>
<long>The green compoent of the foreground color.</long>

Now, if we are to change the short message, we have following choices:
1) "Green foreground color component"
2) "Green component of foreground color"
Somehow, I feel the short definition which goes closest to the long
counterpart: "The green compoent of the foreground color", is
"Foreground color green component".
However, this is just my opinion, and I would like to create the patch
based on your decision.



Comment 5 Breda McColgan 2003-11-24 14:23:06 UTC
Hello,

I'm one of the maintainers of the Help for this applet. 

I think either of the following would be fine:
  <short>Foreground color, green component</short>
  <short>Foreground color: green component</short>



Btw, I presume the misspelling in the <long> text above is just a typo
in this bug, and not in the applet?
  <long>The green component of the foreground color.</long>
                       ^  

Regards,
Breda.
Comment 6 alexander.winston 2003-11-24 14:38:13 UTC
Yeah, I like <short>Foreground color, green component</short> as well.
Comment 7 Kaushal Kumar 2003-11-25 04:31:11 UTC
Sounds good to me, too. I will attach a patch shortly.
Comment 8 Kaushal Kumar 2003-11-25 10:59:21 UTC
Created attachment 21790 [details] [review]
Patch fixes this bug.
Comment 9 Kaushal Kumar 2003-11-25 11:59:20 UTC
I am not able to add the PATCH keyword since I get a permission error.
How do I get this permission?
Comment 10 Christian Rose 2003-11-25 12:12:17 UTC
Kaushal: Contact bugmaster@gnome.org.
Comment 11 Kevin Vandersloot 2003-11-26 20:26:00 UTC
Please commit Kaushal. Thanks a lot.
Comment 12 Kaushal Kumar 2003-11-27 04:42:33 UTC
Fixed in the cvs head.