After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 118474 - gstputbits should be rewritten
gstputbits should be rewritten
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal critical
: 0.7.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-07-28 09:58 UTC by Brian Cameron
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
patch to add putbits.[ch] in places where it's needed (16.59 KB, patch)
2003-07-29 06:24 UTC, David Schleef 		none Details | Review

Description Brian Cameron 2003-07-28 09:58:19 UTC 
The gstputbits plugin (gstreamer/gst/putbits/putbits.[ch]) are under
the MPEG lciense. This license clearly states that there may be IP
in the code.  No plugin in the core should be under any license
that is not LGPL.  This plugin should be rewritten so it can be under
the LGPL, or moved to gst-plugins.  According to my conversations with
Wim Taymans, the putbits plugin is only used by mpegaudio and mpeg2enc.
Comment 1 David Schleef 2003-07-28 23:39:01 UTC 
Does anything use it that shouldn't be dropped?
Comment 2 David Schleef 2003-07-29 06:23:32 UTC 
only gst-plugins/gst/mpegaudio and mpeg2enc use it.  Attached is a
patch to move putbits.[ch] to the mpegaudio and mpeg3enc directories
(curiously, the code base that it came from.)

I favor dumping gstreamer/libs/gst/putbits, and telling people to use
bitstream in codecs.org.
Comment 3 David Schleef 2003-07-29 06:24:42 UTC 
Created attachment 18706 [details] [review]
patch to add putbits.[ch] in places where it's needed
Comment 4 David Schleef 2003-08-06 01:09:21 UTC 
The patch has been committed, and the lib removed from gstreamer.