GNOME Bugzilla – Bug 117997
Please use plural forms in drwright
Last modified: 2004-12-22 21:47:04 UTC
Please read Christian's explanation of the problem and solution at http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#plurals #: src/drwright.c:461 #, c-format msgid "%d minutes until the next break" #: src/drwright.c:464 msgid "One minute until the next break" I'll attach a patch for this below, though it might not be the patch you'd like ("One minute" will become "1 minute", feel free to change that). If you don't mind this patch, I can commit this myself.
Created attachment 18485 [details] [review] Patch to provide plural forms with ngettext()
Can we have this fixed now for GNOME 2.5?
I believe DrWright is *superseeded* by "Typing break" for both Gnome 2.4 and Gnome 2.5, and this module is only relevant to Gnome 2.2 installations. Christian, are you able to change product and component for this bug to "control-center" and "other capplets"/"keyboard" (I'm not really sure what category this should go in), because all of this applies to file gnome-control-center/typing-break/drwright.c instead -- and the patch could probably be used unmodified. If it's better to reopen a new bug, I'll do that.
Sounds good, if the control-center is branched for 2.6, I guess it would be fine to commit.
Okay, commited to gnome-control-center HEAD CVS. Marking as resolved and fixed.
configure.in doesn't seem to properly check for ngettext availability. I thought it was decided that for now, each module using ngettext had to check for its availability by itself?
Created attachment 20549 [details] [review] Proposed patch to require ngettext in gnome-control-center
Okay, this is a patch that would stop in configure if ngettext is not available with error message "ngettext is required" (please give a better suggestion for the message). Is this good enough at this time?
This is for control-center, not drwright. Maybe a separate bug for that module is better?
I believe you're right, this has nothing to do with DrWright itself. I've filed a bug 124064 for control-center (I've added Christophe to CC field). Everyone agrees that it's ok to close this bug again?