GNOME Bugzilla – Bug 117889
daemon uses libgnome header
Last modified: 2005-06-13 13:11:53 UTC
gdm 2.4.2.97 In configure.in PKG_CHECK_MODULES for daemon checks for gdk-pixbuf and gtk+, but not libgnome. Yet many gdm2/daemon/*.c files #include <libgnome/libgnome.h> I guess this can be removed now (perhaps replacing with a gtk header).
I'm being lazy and it can't really be removed. What I'm using it for is the gnome-i18n.h header which sets up the localization stuff. Yes, I should do this myself, but until that time it can't be removed
Kenneth, Carlos, comments?
Created attachment 37389 [details] [review] Proposed patch. The proposed patch includes gi18n.h instead of libgnome.h where appropriate (in all files that contain gettext calls). The include directive has been removed for files that don't contain any gettext calls. Only in one case the include was used for popt. That has been replaced as well.
What about vicious-extensions/ve-gnome.c which uses gnome_i18n_get_language_list()? It's perhaps conditionally compiled-in, so this is a non-issue, but it should not be forgotten.
Committed the patch to CVS head. Leaving bug open since vicious-extensions still needs fixing. Can you patch this as will Christian?
Brian, you can just use g_get_language_names instead of gnome_i18n_get_language_list now. (although vicious-extensions is copy-and-paste code from the vicious-extensions module in cvs, so probably better to make the change there I think)
Ray, would you mind making a patch for gdm2 and for the vicious-extensions module as well? I'm a bit swamped at the moment, otherwise I'll get to this in a few weeks.
Created attachment 47597 [details] [review] Patch Removes gnome_i18n_get_language_list call This is a patch to vicious-extensions to remove the gnome_i18n_get_language_list call, but we're still using gnome_program_locate_file so we can't remove libgnome yet. Just curious, but why are we trying to remove all the libgnome calls? Is this just to make gdm nondependent on it?
libgnome[ui|canvas] are all being deprecated at some point in the future and work is being done to move features from those into gtk+ proper, it will take some time though.
Created attachment 47621 [details] [review] Update This is actually more correct (taken straight from libgnome).
Fixed in CVS head.