After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 117840 - Drop autoconf magic and use G_MODULE_SUFFIX
Drop autoconf magic and use G_MODULE_SUFFIX
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: libgpa
CVS
Other All
: Normal normal
: ---
Assigned To: Chema Celorio
Chema Celorio
Depends on:
Blocks:
 
 
Reported: 2003-07-19 13:04 UTC by Fredrik Jönsson
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to use G_MODULE_SUFFIX rather than homemade (2.14 KB, patch)
2003-07-19 13:06 UTC, Fredrik Jönsson 		none Details | Review

Description Fredrik Jönsson 2003-07-19 13:04:23 UTC 
Build fails for me because of obscure autoconf macro that is completely
unnecessary, glib alredy defines such a symbol in G_MODULE_SUFFIX. Attached
is a patch which uses G_MODULE_SUFFIX instead of home made define.

Actually I don't see why the code that uses this suffix is there at all.
IMHO it seems like a better idea to just throw the found path to
g_module_open(), let the framework deal with any issues and just ignore it
if g_module_open() returns null.
Comment 1 Fredrik Jönsson 2003-07-19 13:06:05 UTC 
Created attachment 18441 [details] [review]
Patch to use G_MODULE_SUFFIX rather than homemade
Comment 2 Jody Goldberg 2003-10-06 23:22:54 UTC 
This is crufty.  The patch looks like a good idea, but wish we didn't need to
bother.  However, it looks like things other than modules can be in that dir.

Lets apply to HEAD.
Comment 3 Morten Welinder 2003-11-05 20:48:54 UTC 
We need to check for the dot too.