After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 117805 - version 0.3.0 does not compile with gcc 2.95
version 0.3.0 does not compile with gcc 2.95
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Dodji Seketeli
Dodji Seketeli
: 122068 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-07-18 22:55 UTC by Manuel Clos
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix this (1.51 KB, patch)
2003-08-20 07:28 UTC, Jens Bech Madsen 		none Details | Review
Patch for cr-lay-eng.c (469 bytes, patch)
2003-08-20 07:42 UTC, Jens Bech Madsen 		none Details | Review
Proper patch for cr-lay-eng.c (590 bytes, patch)
2003-09-12 04:51 UTC, Jens Bech Madsen 		none Details | Review

Description Manuel Clos 2003-07-18 22:55:34 UTC 
Does not compile with gcc 2.95:

cr-sel-eng.c:140
cr-sel-eng.c:792

cr-lay-eng.c:1221
Comment 1 Wayne 2003-07-21 00:47:09 UTC 
cr_lay_eng.c in cvs has a function call before a declaration. This
seems to be the problem.
Comment 2 Dodji Seketeli 2003-07-21 10:24:23 UTC 
Okay, I will fix this asap.
Thank you for the bug report.

Dodji.
Comment 3 Jens Bech Madsen 2003-08-20 07:28:36 UTC 
Created attachment 19371 [details] [review]
Patch to fix this
Comment 4 Jens Bech Madsen 2003-08-20 07:42:32 UTC 
Created attachment 19372 [details] [review]
Patch for cr-lay-eng.c
Comment 5 jbuck 2003-09-11 23:55:53 UTC 
*** Bug 122068 has been marked as a duplicate of this bug. ***
Comment 6 jbuck 2003-09-11 23:57:24 UTC 
The bug is still present in the libcroco that shipped with Gnome 2.4.
Two files are affected.
Comment 7 jbuck 2003-09-12 00:05:15 UTC 
The proposed patch dated 8/20 is wrong!  It moves a dereference of
a pointer to occur before the check.  Also, it fixes only one of the
two files that miscompile.
Comment 8 Jens Bech Madsen 2003-09-12 04:51:28 UTC 
Created attachment 19886 [details] [review]
Proper patch for cr-lay-eng.c
Comment 9 Jens Bech Madsen 2003-09-12 04:54:15 UTC 
Patch 19371 fixes cr-sel-eng.c
Comment 10 Dodji Seketeli 2003-09-12 05:58:38 UTC 
This is fixed in CVS Now.