After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 117173 - space and return download article twice
space and return download article twice
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-0.14.1 betas
Other Linux
: Normal minor
: 0.14.1
Assigned To: Charles Kerr
Pan QA Team
: 117245 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-07-11 03:45 UTC by Johan
Modified: 2006-06-18 05:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Johan 2003-07-11 03:45:31 UTC 
New since 0.14.0, when reading a specific using arrow buttons and return,
or when hitting space at end of article, the following article is added to
the queue twice. When selecting with mouse or 'n', the article is correctly
added only once.
Comment 1 dcb 2003-07-12 02:12:17 UTC 
*** Bug 117245 has been marked as a duplicate of this bug. ***
Comment 2 Charles Kerr 2003-07-14 18:43:15 UTC 
Confirmed.  The first task is added from here:

+ Trace 38691

  • #0 queue_add
    at queue.c line 460
  • #1 text_set_from_identifiers
    at text.c line 965
  • #2 articlelist_read_article
    at articlelist.c line 584
  • #3 header_pane_first_selected
    at articlelist.c line 279
  • #4 articlelist_read_selected
    at articlelist.c line 625
  • #5 return_pressed_in_header_pane
    at gui.c line 825
  • #6 header_pane_forall_selected
    at articlelist.c line 287
  • #7 gui_page_activate_nolock
    at gui.c line 846
  • #8 gui_key_press_cb
    at gui.c line 876
  • #1 queue_add
    at queue.c line 461
  • #2 text_set_from_identifiers
    at text.c line 965
  • #3 articlelist_read_article
    at articlelist.c line 584
  • #4 header_pane_first_selected
    at articlelist.c line 279
  • #5 articlelist_read_selected
    at articlelist.c line 625
  • #6 return_pressed_in_header_pane
    at gui.c line 825
  • #7 header_pane_forall_selected
    at articlelist.c line 287
  • #8 gui_page_activate_nolock
    at gui.c line 846
  • #9 gui_key_press_cb
    at gui.c line 876 






Comment 3


Charles Kerr





          2003-07-14 18:48:23 UTC
        



Ooops, that should've read that the second task is added from here:





+
Trace
    38692






    

  • 
#0
queue_insert_tasks

    
                at queue.c
                  line
                  588

    

    • 

  • 
#1
queue_add

    
                at queue.c
                  line
                  461

    

    • 

  • 
#2
queue_task_bodies

    
                at article-actions.c
                  line
                  614

    

    • 

  • 
#3
header_pane_forall_active

    
                at articlelist.c
                  line
                  306

    

    • 

  • 
#4
article_action_download_selected

    
                at article-actions.c
                  line
                  619

    

    • 

  • 
#5
articlelist_read_selected

    
                at articlelist.c
                  line
                  628

    

    • 

  • 
#6
return_pressed_in_header_pane

    
                at gui.c
                  line
                  825

    

    • 

  • 
#7
header_pane_forall_selected

    
                at articlelist.c
                  line
                  287

    

    • 

  • 
#8
gui_page_activate_nolock

    
                at gui.c
                  line
                  846

    

    • 

  • 
#9
gui_key_press_cb

    
                at gui.c
                  line
                  876

    

    • 













Comment 5


Charles Kerr





          2003-07-17 02:45:48 UTC
        



Chris Petersen says, of 0.14.0.91:

> oh, and that "download multiples when hitting return" problem is
> still there when you select more than one article and then hit
> return.  I actually get 3 instances when I do this..   two
> of "downloading # articles" and one of just downloading whichever
> article was the last one "touched" during selection.







Comment 7


Charles Kerr





          2003-07-29 18:26:21 UTC
        



Chris Petersen says of 0.14.0.92:

> didn't fix it.  Now instead of downloading the selected group of
> articles more than once, it only downloads the first article (once).
> That's more annoying than before.







Comment 8


Charles Kerr





          2003-08-04 17:11:09 UTC
        



I'm unable to reproduce this.  Activation through pressing
"Enter" seems to work correctly:

single selected article, has replies, replies are expanded:
the selected article is downloaded once and shown in the body pane. 

single selected article, has replies, replies are collapsed:
the selected article and its descendents are downloaded once.
the selected article is shown in the body pane.

multiple selections in a thread:
the selected articles and their collapsed descendents are d/l'ed once.
the first selected article is shown in the body pane.

multiple selections, multiple threads:
same behavior as "multiple selections in a thread".






Comment 9


Charles Kerr





          2003-08-04 17:15:23 UTC
        



Chris: marking this as NEEDINFO -- as described in my last comment,
as far as I can tell Pan is behaving correctly when activating
with the Enter key.  What exactly is Pan doing wrong for you?






Comment 10


Chris Petersen





          2003-08-05 18:20:08 UTC
        



0.14.0.94, Redhat 9

Articles are no longer downloaded twice.  However, when I select a
group of (binary) articles and press enter to read them, only the
first article is downloaded/read/cached, and the others are
essentially ignored as if only the first one had been selected.  No
threads, just plain old complete-binary articles (not sure what
happens for non-binary articles, though I don't see what it would be
very different, since only one task is being entered).