After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116809 - shift+click on link should prompt to save file
shift+click on link should prompt to save file
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2003-07-06 10:36 UTC by Marius Andreiana
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
prompt to download link on shift click (1.92 KB, patch)
2003-08-15 06:09 UTC, Jon Willeke
none Details | Review

Description Marius Andreiana 2003-07-06 10:36:38 UTC
get dialog to select file name and then save file ( same as in galeon ).
Comment 1 Reinout van Schouwen 2003-07-26 23:33:27 UTC
Galeon has removed this feature lately. Anyone know the reason why? At
first sight this seems a reasonable request, as Netscape has behaved
like this since the beginning of recorded history...
Comment 2 Marco Pesenti Gritti 2003-07-27 12:01:59 UTC
Uhm I actually see comments about having added it in galeon, not removed.
Comment 3 Marco Pesenti Gritti 2003-08-13 19:28:04 UTC
Alan comment:

It has annoyed me many times when trying to use IE that it
behaveddifferently from Mozilla.  The wisest thing to do is probably
to followMozilla's behaviour.In mozilla Shift Click gives a save
(download) dialog,Ctrl+Click opens a new window also if you have a
three button (or wheel)mouse middle click will open a new window.
Comment 4 Jon Willeke 2003-08-15 06:06:00 UTC
I've seen several sites that advise shift clicking to download a file.
 I think it's a convention worth keeping.

I'm attaching a patch against 0.8.2.  
Comment 5 Jon Willeke 2003-08-15 06:09:01 UTC
Created attachment 19230 [details] [review]
prompt to download link on shift click
Comment 6 Marco Pesenti Gritti 2003-08-15 08:04:56 UTC
Unfortunately we are freezed until September and we cant check in the
patch. I'll look at it as soon as we branch though. (2 weeks or so).
Comment 7 Jon Willeke 2003-08-17 18:33:14 UTC
Please see bug 110786 for an updated version of this patch that also
recognizes Ctrl-click.
Comment 8 Christian Persch 2003-09-16 10:41:19 UTC
Should we also support saving an image with mod+click? Galeon 1.x had
this behaviour, and I sort of liked it...
It used ctrl+click, but if it's universally agreed that ctrl+click
should open a link in a new window/tab, we could use alt or sth.
Comment 9 Marco Pesenti Gritti 2003-09-16 11:04:05 UTC
Cant we use shift click for images to ? The action is the same, save ...
Comment 10 Christian Persch 2003-09-16 11:42:18 UTC
The problem is with images which are links ... would the shift+click
save the image, or the linked file?
Comment 11 Marco Pesenti Gritti 2003-09-16 11:48:20 UTC
I see hmmm. I'd just like to keep the number of accels low, they are
completely arbitrary...
Dave, opinions ?
Comment 12 Dave Bordoley [Not Reading Bug Mail] 2003-09-16 16:35:16 UTC
i'm ok with shift-click == download link. Also i think alt+click
should be the equivalent of middle-click everywhere as well.
Comment 13 Marco Pesenti Gritti 2003-09-16 16:36:57 UTC
What about images ? See chpe comment.
Comment 14 Dave Bordoley [Not Reading Bug Mail] 2003-09-16 16:48:48 UTC
First, I don't think ctrl+click should do anything other than
disjointed selection in a file manager :P Alt+click is somewhat
standard, although now that I think of it alt+click may be used single
button mouse users to display context menus. OF course nautilus uses
alt+drag to be the equivalent of middle-click and drag. hmmm...

ok, regarding chpe's comment i think the behavior should be
consistent, ie. if you shift+click a thumbnail it downloads the full
picture that the thumbnail link points at. However shift+clicking a
jpeg for instance should do nothing. My guess is that the amount time
it takes you to think and use the keymodifier is significantly slow
enough where where file->save will be faster to use (or if you're into
making your self slower you can use ctrl+s). Might need to ask seth
his take on this too, but I'd guess that he'd agree that keyboard
modified mouse click take about as long to think about as keyboard
shortcuts do.
Comment 15 Christian Persch 2003-12-08 15:24:51 UTC
The patch in bug 110786 contained shift-click to save as well,
altough, in line with our current downloading behaviour, it does not
prompt.

Btw, we can't use alt-click for anything since metacity steals those :/