After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116606 - gradients not saved until quit
gradients not saved until quit
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
1.x
Other All
: Normal enhancement
: 2.0
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2003-07-03 07:49 UTC by Aaron Brick
Modified: 2003-11-11 19:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Aaron Brick 2003-07-03 07:49:56 UTC
i edited some gradients and expected them to be saved when i closed them.
however, the files are updated only when i exit the application. why wait?
Comment 1 Sven Neumann 2003-07-03 11:22:59 UTC
Well, why not?
Comment 2 Aaron Brick 2003-07-03 18:02:50 UTC
in my case, it was because i needed to edit the gradients and then
export them to another machine - i was installing a web site. i hope
you'll agree that this has little to do with whether the GIMP is running.

also, i was trying to learn the gradient file format, and without
being able to see my changes right away, it was a challenge.
Comment 3 Sven Neumann 2003-07-03 18:09:03 UTC
In the 1.3 tree the functionality to save and revert is already
foreseen but not yet implemented. This should be completed before the
next release. We won't change this behaviour in the 1.2 tree however.
Comment 4 Aaron Brick 2003-07-03 18:32:32 UTC
fair enough, thanks Sven.
Comment 5 Dave Neary 2003-07-26 10:33:39 UTC
Bumping a bunch of enhancement requests which will not be done by the feature
freeze to Future. 

Dave.
Comment 6 Michael Natterer 2003-07-29 12:38:24 UTC
The functionality is almost there. Setting back to 1.3.
Comment 7 Dave Neary 2003-10-27 16:58:09 UTC
Hi,

This may be a silly question, but what's wrong with  the trivial
implementation 

static void
gimp_data_editor_save_clicked (GtkWidget      *widget,
                               GimpDataEditor *editor)
{
  GimpData *d = gimp_data_editor_get_data(editor);
  GError *e = NULL;
  gimp_data_save(d, &e);
  if (e != NULL)
  {
    // do stuff with error
  }
}
                                                                     
          
Sven mentioned that there was a problem with doing this trivially, but
I can't see one. What was the problem?

Cheers,
Dave.

Comment 8 Dave Neary 2003-11-10 21:02:13 UTC
2003-11-10  Dave Neary  <bolsh@gimp.org>
 
        * app/widgets/gimpdataeditor.c: Implement save button. Partially
        addresses bug #116606.


This gives a workaround - when you click the save button the data
being editted is saved instantaneously.

To have the editor save data on closure of the window, we need to
over-ride the _destroy() function for gimpeditor, I think, but I may
be wrong about that. 

Is there any way to get at and save dirty data in gimp_editor_destroy()? 

Dave.
Comment 9 Dave Neary 2003-11-11 19:00:34 UTC
Fixed in HEAD:

2003-11-11  Dave Neary  <bolsh@gimp.org>
 
        * app/widgets/gimpdataeditor.c: Save data before disposing of
        it when closing the dialog. Closes bug #116606.