After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116420 - lame metadata: write id3 v1 and v2 tags in encoded files
lame metadata: write id3 v1 and v2 tags in encoded files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.x
Other Linux
: Normal normal
: 0.6.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 112567 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-06-30 23:30 UTC by Bastien Nocera
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
new feature (4.58 KB, patch)
2003-06-30 23:30 UTC, Bastien Nocera 		none Details | Review
updated to use tracknumber like the vorbis plugin (4.61 KB, patch)
2003-07-05 17:25 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2003-06-30 23:30:17 UTC 
New feature, necessary to use Sound-Juicer with the mp3 encoding selected.
It uses fields with the same name as the vorbisenc plugin does. Patch attached.
Comment 1 Bastien Nocera 2003-06-30 23:30:56 UTC 
Created attachment 17947 [details] [review]
new feature
Comment 2 Bastien Nocera 2003-06-30 23:37:21 UTC 
*** Bug 112567 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2003-07-01 19:14:39 UTC 
after double-checking, the bitrate information is set properly on the
file. Can you merge please?
Comment 4 Benjamin Otte (Company) 2003-07-02 15:57:06 UTC 
marking 0.6.3, so it gets in there. HEAD will be fixed differently.
Comment 5 Thomas Vander Stichele 2003-07-04 07:34:50 UTC 
bastien, what does the change in flush from nogap to "" do exactly ?

Benjamin, what exactly would be done different in HEAD ?
Comment 6 Bastien Nocera 2003-07-04 09:17:44 UTC 
_flush allows the id3 v1 tags to be written on the file. no_gap is
only used if you want to keep on writing the stream, and keep on using
the same encoder. I would expect people to destroy the encoder when
they done encoding a file and want to pass on to another one.

Bear in mind that the _FLUSH event isn't used and that this only
happens on _EOS.
Comment 7 Bastien Nocera 2003-07-05 17:25:31 UTC 
Created attachment 18061 [details] [review]
updated to use tracknumber like the vorbis plugin
Comment 8 Thomas Vander Stichele 2003-07-05 22:50:15 UTC 
commited to 0.6.x branch and HEAD, closed.