After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 116217 - desktop_is_home_dir only changes desktop icons when nautilus restarts
desktop_is_home_dir only changes desktop icons when nautilus restarts
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
2.12.x
Other All
: Normal normal
: 2.12.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-28 21:17 UTC by Jeff Waugh
Modified: 2005-09-26 15:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Proposed patch (4.79 KB, patch)
2005-09-07 21:56 UTC, Christian Neumair
committed Details | Review

Description Jeff Waugh 2003-06-28 21:17:24 UTC
Expected behaviour:

- i'd expect, when turning desktop_is_home_dir on or off, that the desktop
icons would appear and disappear as soon as you click it

Current behaviour:

- the desktop folder emblem correctly changes
- the icons on the desktop don't appear or disappear (changing from either
state), even though they can be fully functional (when changing from
desktop_is_home_dir = true)

(did i explain this well enough? it almost sounds like bunkus)
Comment 1 Christian Neumair 2005-05-13 17:01:04 UTC
Thanks for your bug report! I'll look into it...
Comment 2 Christian Neumair 2005-05-13 17:56:39 UTC
The code looks a bit tricky...nautilus_window_go_to (win, EEL_DESKTOP_URI) is
called for the desktop window when this key changes, but
nautilus_desktop_directory_instance_init isn't called. Maybe the problem is that
the desktop directory is assumed to have not changed and the same old instance
is still used.
Comment 3 Christian Neumair 2005-09-07 21:56:26 UTC
Created attachment 51937 [details] [review]
Proposed patch

I've also submitted this patch to the nautilus mailing list [1] for review.

[1] http://mail.gnome.org/archives/nautilus-list/2005-September/msg00083.html
Comment 4 Christian Neumair 2005-09-07 21:57:40 UTC
Updating bug information. Milestoning to 2.12, since I think this is a bugfix
rather than a feature addition.
Comment 5 Christian Neumair 2005-09-26 15:19:26 UTC
Committed, closing.