After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115355 - "System default" language setting doesn't say what that language is
"System default" language setting doesn't say what that language is
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Preferences
0.x
Other All
: Low minor
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2003-06-17 12:53 UTC by spark
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix, needs portability changes (3.20 KB, patch)
2003-07-19 10:46 UTC, Christian Persch
none Details | Review

Description spark 2003-06-17 12:53:12 UTC
"System default" language setting doesn't say what that language is.

In advanced prefs. If my default is English, should show:

...
English (System Default)
...
Comment 1 Marco Pesenti Gritti 2003-07-18 22:20:06 UTC
Chpe, you had an idea on how to implement this ? We need to get it in
before 31. I remember we discussed it but I forgot all details :/
Comment 2 Christian Persch 2003-07-18 22:40:13 UTC
My proposal was to simply add a comment in the source for the
translators. For example, in my en_GB translation, i translate 'System
default' to 'British English (Default)'.
This takes care of the case when there is a transation available for
the user's locale.

Now, in case the user's locale does _not_ have a translation, we still
pick up the two-letter code, but currently the user can't tell that
from the 'System language' string. I thought of using suitable _NL_*
arguments to nl_langinfo, and use that to build the ui string. But the
glibc docs say those _NL_* we'd be interested in are a GNU extension,
so we'd leave out non-GNU systems. Still, could be better than
nothing. What do you think?
Comment 3 Marco Pesenti Gritti 2003-07-18 22:45:07 UTC
Sounds good. As long as we add proper checks for system that doesnt
have  that func ...
Comment 4 Christian Persch 2003-07-19 10:46:58 UTC
Created attachment 18437 [details] [review]
proposed fix, needs portability changes
Comment 5 Marco Pesenti Gritti 2003-07-19 14:44:16 UTC
Looks good. For portability we can just copy glib checks I guess.
Comment 6 Marco Pesenti Gritti 2003-07-21 19:53:26 UTC
So we need to check in the translators comment before July 31.
Comment 7 Christian Persch 2004-01-15 19:31:06 UTC
The translator's comment has been there since before 1.0, but still
almost all translations don't follow it. I think we should file bugs
against translations which don't follow it, and close this bug.
Further work seems like lost time since we will abandon this setting
after 1.2 (see bug 130446).
Comment 8 Christian Persch 2004-04-08 22:01:51 UTC
Comment on attachment 18437 [details] [review]
proposed fix, needs portability changes

Marking obsolete attachments in open bugs.
Comment 9 Christian Persch 2004-07-25 11:44:19 UTC
L10n applet didn't make 2.8, so we still need to deal with this for 1.4.0.
Someone needs to mass-file bugs against translations.
Comment 10 Christian Persch 2004-10-13 10:54:27 UTC
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Comment 11 Christian Persch 2004-11-07 15:39:24 UTC
Fixed in cvs. It now reads like this: "System language [en]".