After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115052 - gst_pad_selectv() doesn't follow the va_list convention
gst_pad_selectv() doesn't follow the va_list convention
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.7.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-12 22:12 UTC by David Schleef
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Schleef 2003-06-12 22:12:56 UTC 
In most GNOME software (afaict) functions that take variable arguments
("func()") have a corresponding function that takes a va_list, called
"funcv()".  Most of GStreamer follows this convention.  gst_pad_select
(GList *padlist) and gst_pad_selectv (GstPad *pad, ...) don't follow this
convention.

I think we should officially adopt this convention and fix functions that
don't follow it.
Comment 1 Ronald Bultje 2003-06-20 13:21:28 UTC 
I agree with this, it's inconsistent.

However, we obviously cannot fix this in 0.6.x, no matter how much I'd
love to. We probably do want to add a valist function alternative to
0.6.x, too, but this'd have a different name than the valist/vararg
functions in HEAD. The list function might be dropped (not sure how
badly it's needed specifically), or we might want to rename it to
gst_pad_select_list().

Comments? I can provide a patch if wanted.
Comment 2 David Schleef 2003-07-25 03:20:47 UTC 
/me was wrong.

Upon perusal of glib, some_functionv() is a function that is just like
some_function(), except the last argument is a pointer to a NULL
terminated list of a specific type, typically a pointer.

some_function_valist() is just like some_function(), except it takes a
va_list type as the final argument.
Comment 3 David Schleef 2003-12-02 04:42:06 UTC 
These should all be fixed now, either in HEAD or CAPS.