GNOME Bugzilla – Bug 115037
"empty trash" should be above properties
Last modified: 2016-10-11 16:42:54 UTC
In the context menu of the trash icon and the icons for mounted media, the empty trash and unmount items, respectively, should be above, not below the properties item. This is to provide consistency, otherwise people will be enclined to click the wrong item.
This would be nice to fix as it causes a lot of confusion in my experience.
Created attachment 38802 [details] [review] Proposed patch This patch moves the properties item to the bottom. Don't hate me, but while I was there, I couldn't resist fixing some typos and tab/space mishaps.
I disagree. The Trash is a special icon and should IMHO get its own menu. Most options are greyed out anyway. See Bug 170738 . The most common item selected is most likely "Empty Trash" and should be best reachable. The top and bottom items are accessible best IMHO. I would even suggest putting this option on top or bottom depending on the menu opening up- or downwards. The idea is this item should me next to the mouse pointer.
Bug 91437: Trash bin should have it's own custom context menu
Usability team, what do you think? Should these special items go above or below the properties item?
I vote for 'above'. I can't remember if it's currently in the HIG or not, but we did discuss a standard structure for context menus at one point, which said that Properties should always appear at the bottom, when it's applicable.
Calum: Is it a good idea to commit it after UI freeze?
Probably not important enough for that, no.
Michael: We're now heading Nautilus 2.14, and your patch is a candidate for inclusion. However, we've committed a patch that fixes the typos your patch targetted, so you'll have to write it again. As soon as your patch is written, please send it to the Nautilus mailing list [1] for review. Are you still willing to work on the issue? [1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Created attachment 53388 [details] [review] Shiny new patch Against current CVS. That'll teach me to make tangential fixes. :)
Actually, I think it makes more sense if the eject/empty trash menu items are showed in the same place where the move to trash menu item is normally shown (hiding the move to trash item of course).
Marking attachment 53388 [details] [review] as "needs-work" based on Alex's comment. Michael, are you able to update your patch?
Yeah, I'm on it.
Created attachment 56525 [details] [review] Empty trash w/ move to trash How's about this, gents?
Micahel: Thanks for your efforts, sorry that it didn't make it in for 2.14, we're UI frozen. I'm milestoning this to 2.16 and I'd like you to submit your patch after we've branched off for 2.14 to the Nautilus mailing list [1] for review. [1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Christian this patch went to the tree or needs work ?
Isn't this already fixed? In my GNOME 2.20 installation, "Unmount Volume" is above "Properties".
It is changed for unmount volume but the issue with the trash still exists, making the UI a little more inconsistent.
While not visible in a regular GNOME 3 desktop anymore, it can be seen that "Empty Trash" is still below "Properties" if running fallback mode or having enabled a trash desktop icon with gnome-tweak-tool, so it might still be worthwhile to fix. An updated version of the patch Micheal Tarry provided in comment #14 would probably do the trick.
guys, is this bug still valid?
this was fixed a while ago