After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 114411 - [PATCH] Display/Print Embedded Headers; RFC + Review
[PATCH] Display/Print Embedded Headers; RFC + Review
Status: RESOLVED FIXED
Product: balsa
Classification: Other
Component: general
2.0.x
Other All
: High enhancement
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-04 18:58 UTC by albrecht.dress
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
proposed patch (11.96 KB, application/octet-stream)
2003-06-04 18:59 UTC, albrecht.dress
Details

Description albrecht.dress 2003-06-04 18:58:29 UTC
Below is a patch to display and print the headers of embedded
message/rfc822 parts (such parts are usually a result forward->attached
messages). To enable re-using of existing code, I moved the displayed
headers into a new structure which is used from both libbalsa/message.[hc]
(for the "main" headers) and libbalsa/body.[hc] (embedded). This causes
many tiny changes in a lot of files, making this patch so big.

I tried to be extra paranoid to check if the headers structure is present
when needed. These checks will usually be useless, as the structure will be
there as long as memory is available (and maybe no very strange race
conditions occur?), but I like to be safe... Of course you could remove them.

Details:

- libmutt/parse.c:
make libmutt extract headers from embedded messages

- libbalsa/libbalsa.h:
typedef LibBalsaMessageHeaders

- libbalsa/message.[hc]:
define & use LibBalsaMessageHeaders, define some helper functions, define
the infrastructure to create and destroy the new struct, handle headers
being moved to the new (sub-)struct

- libbalsa/body.[hc]:
add headers to the body struct and take care to allocate, set and free them

- libbalsa/filter.c, libbalsa/send.c:
handle headers being moved to the new struct

- src/balsa-message.c:
move stuff to display headers to a new function (display_headers_real)
which is called via wrappers to render both the main and the embedded
headers, handle headers being moved to the new struct

- src/print.c:
same for printing

- src/balsa-index.c, src/sendmsg-window.c, src/store-address.c:
handle headers being moved to the new struct
Comment 1 albrecht.dress 2003-06-04 18:59:15 UTC
Created attachment 17145 [details]
proposed patch
Comment 2 manu 2003-06-14 23:18:56 UTC
Albrecht please repost your patch but with a correct type (plain-text
patch). I had too much problems to use it.
Thanks
Comment 3 Carlos Morgado 2003-06-14 23:22:12 UTC
It's bzip2
Comment 4 manu 2003-06-15 17:10:58 UTC
Oops sorry I missed that. PEBKAC ;-)
Comment 5 albrecht.dress 2003-10-06 18:59:14 UTC
It's in since some time!
Comment 6 Carlos Morgado 2003-10-06 21:41:29 UTC
ok, closing