Created attachment 17139 [details] [review]
forward upstream events by default

Why is this needed?  For example, if you insert a tee or identity
element in your pipeline then you want upstream events forwarded
through these elements.

Created attachment 17143 [details] [review]
What about that one for tee

Created attachment 17144 [details] [review]
The first one was sending the event to emitting pad which is wrong

Maybe that's totally stupid but my idea was that event should go
downstream in the other branches of tee ..

Does that make sense ?

There are two patches here.  i don't know about extra forwarding in
tee, but the default upstream event behavior needs to change.

Also beware of reference count problems.  i really don't understand
when to incr ref counts.

This is not the right fix.

If a pad does not have an event handler, it's a scheduler bug. (We
should probably emit a g_warning there.) Schedulers set the event
handler (which just calls the event function normally). And the event
function is set in gst_real_pad_init, so there should always be one
present.

And Julien, you may not change the direction of events so that event
handler is wrong.

I changed it to a g_warning().  The patches in this bug are incorrect.