GNOME Bugzilla – Bug 114098
No Undo/Redo for some SheetObjects
Last modified: 2009-04-20 14:14:23 UTC
(low importance) 1. New spreadsheet, add a checkbox sheet object 2. Open the properties dialog for the checkbox 3. Select a cell to link to, exit the property dialog 4. Undo Undo backs up the creation of the sheet object, not the modification of one of its properties
Several other items are missing the undo too, see BUGS.
I just added undo for line/arrow/rectangle/oval/text and eventually polygon
*** Bug 360880 has been marked as a duplicate of this bug. ***
I have justed added undo for combo and list boxes (as a sideeffect of making the properties dialog working.)
Frames also have undo now.
Checkboxes have undo.
Created attachment 132834 [details] [review] fix for the remaining sheet objects This patch will provide undo/redo for the remaining sheet objects. It doesn't look like I will be able to commit this (or fix it if necessary) for a long while.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
This makes gnumeric require gtk 2.14, which dates from September 2008. This is so recent that I don't think we should make it a hard dependency. The symbols gnumeric complains about with gtk 2.12 (e.g Ubuntu 8.04) are gtk_adjustment_configure gtk_adjustment_get_lower gtk_adjustment_get_upper ` gtk_adjustment_get_page_increment gtk_adjustment_get_step_increment gtk_adjustment_get_page_size Could we fix the problem in another way, not relying on these symbols, or only if they are available? Alternatively, we could probably live without undo when built on older systems.
IRC log fragment about this: <jean> we can replace the symbolds: #define gtk_adjustment_get_lower(adj,x) adj->lower = x <jk_work> right, but that field is probably being GSEALed, which I why they made <jk_work> the new accessors. <jk_work> So we should conditionally use one or the other, may be even using <jk_work> wrappers in goffice
Created attachment 132959 [details] [review] should fix compilation with gtk+-2.12 and older
patch commited with a few fixes.
Seems ok, but I notice that when I change a scroll bar, I get lots of entries in the undo list. I would have hoped to get precisely one for whereever I release the drag.
Morten: These lots of entries when you change a scrolbar has been there for a long time. The new changes just make the configuration undoable. Changing adjustments were made undoable by Jody ages ago.