After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113581 - correct .h, .m4 and .pc files installation
correct .h, .m4 and .pc files installation
Status: RESOLVED FIXED
Product: gnomemm
Classification: Deprecated
Component: libbonobomm
2.0
Other FreeBSD
: Normal trivial
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2003-05-23 07:54 UTC by Alexander Nedotsukov
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cumulative patch for .h, .m4 and .pc installation (2.44 KB, patch)
2003-05-23 07:55 UTC, Alexander Nedotsukov
none Details | Review

Description Alexander Nedotsukov 2003-05-23 07:54:01 UTC
- libbonobomm installs files into libgnomemm ang gtkmm directories.
- does not install library specific convert.m4 macro
- installs libbonobomm-2.0-uninstalled.pc
Comment 1 Alexander Nedotsukov 2003-05-23 07:55:22 UTC
Created attachment 16766 [details] [review]
cumulative patch for .h, .m4 and .pc installation
Comment 2 Murray Cumming 2003-05-23 08:07:48 UTC
Looks good. This should be applied.
Comment 3 Murray Cumming 2003-05-28 18:03:21 UTC
Hmm, don't apply this just yet. It changes where the extra .m4 files
are installed. I need to look at libbonobouimm and adapt it accordingly.
Comment 4 Alexander Nedotsukov 2003-05-29 00:53:35 UTC
Does http://bugzilla.gnome.org/show_bug.cgi?id=113582 supposed to do
this adaptation?
The idea was to make libbonobo*mm modules use same hierarchy as other
modules do.
Give me a hint what I probably missed doing so. I'll be happy to look
into it closer.
Comment 5 Murray Cumming 2003-05-29 09:03:55 UTC
This ChangeLog entry is informative. I'll add it to the file as a comment:
http://cvs.gnome.org/bonsai/cvslog.cgi?file=%2Fgnomemm%2Flibbonobomm%2Ftools%2Fm4%2FMakefile.am

It's obviously not perfect, but it'll do for now. I guess we should
use something in the pkgconfig file to do it properly. We already get
the gtkmmproc location from pkgconfig. Maybe an m4 macro that used
pkgconfig would make it even easier.

By the way, this is even when I correct the mispelling of bonobo.

I'll commit the fixed version later today.
Comment 6 Murray Cumming 2003-05-29 17:31:22 UTC
Applied. Thanks.
Comment 7 Alexander Nedotsukov 2003-05-31 05:54:33 UTC
Since you decided to keep m4 installation directory. Last line in
tools/m4/Makefile.am:

tools_m4_include_HEADERS = $(files_tools_m4)

becomes dangerous. It will result in overwriting of original
gtkmm-2.0/proc/m4/convert.m4. Can not see any quick good solution to
avoid this. Only not to install libbonobomm's convert.m4 as it was before.
Comment 8 Alexander Nedotsukov 2003-05-31 05:55:47 UTC
Forgot to add. This is true for libbonobouimm as well.
Comment 9 Murray Cumming 2003-06-05 06:35:44 UTC
Hmm. I don't think this is actually a bug, because it does work, but 
it needs investigation.
Comment 10 Murray Cumming 2003-06-13 07:58:26 UTC
I have corrected this, but I haven't had a chance to check it in yet.
Comment 11 Murray Cumming 2003-07-08 16:49:24 UTC
Done, I believe.