GNOME Bugzilla – Bug 113472
Shift+Reload should force page reload in Epiphany
Last modified: 2004-12-22 21:47:04 UTC
Most Netscape- and Mozilla-based browsers support pressing Shift and clicking on the Reload button as a means of forcefully reloading a page from the server and bypassing the cached contents. This would be useful to have in Epiphany too.
IF we do this we ought to support an accessible keybinding as well, perhap shift+ctrl+R. Menthos do you know of any such binding that is commonly used?
http://developer.gnome.org/projects/gup/hig/1.0/userinput.html#keyboard The HIG has shortcut recommendations for this.
INteresting, since technically epiphany "Reload" isn't really "Reload" as defined by the HIG, but "Smart Reload." I don't really think any extra menu entries are necessary here, so I'm incline to bend the hig recommendation and bind "Real Reload" as proposed here to Shift+Ctrl+R. Menthos you agree?
Shift is sort of standard, if we change it no one will find it.
marco, i meant in addition to shift+click on reload. Not in place of.
The way this should be implemented if someone want to take it. It's enough to implement a special button action, a generic name would be nice, so we can bind other special behaviors to it in case it's necessary. The action should registered with other custom actions in toolbar.c, and should emit a different signal for shift, or prolly better to extend activate with a mask ...
Created attachment 16770 [details] [review] implementation
Christian: For a11y, you should also probably support shift+return, shift+KP_return, and shift+spacebar on the button. Also might be good to add a generic shift+ctrl+r keybinding for this. /me tries to make billh happy :)
I think we should use the same action for menu and toolbar. The menu item creation should just work I guess. Why are we using the button_release event ? Cant we use the clicked tool button event + gtk_get_current_event ?
Ugh prolly we can use gtk_get_current_event directly in the default callback, without requiring a custom action. Sorry for the bad tip :/ /me is cooked and is doing a lot of silly things lately
>For a11y, you should also probably support shift+return, >shift+KP_return, and shift+spacebar on the button. These should just work in the way I proposed.
Created attachment 16795 [details] [review] much simpler patch
Looks good, please commit if you got access, otherwise I'll do it later.
checked in