After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113318 - minor 64-bit cleanliness issue
minor 64-bit cleanliness issue
Status: VERIFIED FIXED
Product: libxslt
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Daniel Veillard
Daniel Veillard
Depends on:
Blocks:
 
 
Reported: 2003-05-20 01:44 UTC by Kelledin
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2

Attachments
res_ptr 64-bit fix (736 bytes, patch)
2003-05-20 01:45 UTC, Kelledin 		none Details | Review

Description Kelledin 2003-05-20 01:44:19 UTC 
This applies specifically to version 1.0.30.  To the best of my knowledge, earlier versions do 
not have this problem. 
 
In libxslt/variables.c, line 904, the code makes the mistake of stuffing a pointer into an int.  
Aside from the ugly compiler warning, if pointers are are larger than ints (as they are on my 
EV56), some upper bits of the pointer get lost.  In rare circumstances, this could result in the 
comparison on line 905 generating a false-positive. 
 
I'm attaching a patch below that should take care of this problem.
Comment 1 Kelledin 2003-05-20 01:45:15 UTC 
Created attachment 16649 [details] [review]
res_ptr 64-bit fix
Comment 2 Daniel Veillard 2003-05-20 10:15:32 UTC 
Okay, exact, I'm suprized I let that go though, the fix is right,
applied and commited to CVS,

  thanks a lot !

Daniel
Comment 3 Daniel Veillard 2003-07-07 14:15:41 UTC 
this should be closed by release of libxslt-1.0.31
                                                                     
          
  thanks,
                                                                     
          
Daniel