GNOME Bugzilla – Bug 113265
Pan loses articles when header download gets socket error + status cosmetic fixes.
Last modified: 2004-12-22 21:47:04 UTC
1. Connections with my NNTP server seem to stall quite often. If downloading article headers stalls, pan eventually times out the transfer and reports "Error Reading from socket" in a status item at the bottom of the screen. When pan goes to retry the request, it downloads no more articles because it updated the high count for the group to the high count retrieved from the nntp_get_group_info call instead of the highest article number that was actually retrieved from the NNTP server before the transfer stalled. This bug causes pan to miss articles in a group. 2. When loading file headers or downloading new article headers, pan never updates the status bar to show that it loaded the total number that it reported on the status emit steps. It always falls short by a value less than the step value. Attached to this bug is a patch file that attempts to correct these problems.
Created attachment 16620 [details] [review] Recursive context diff with fixes for problems on bug report.
*** Bug 117116 has been marked as a duplicate of this bug. ***
Hi Tom, Thanks for the report, and more importantly, for the patch! :) I added a new variable to nntp_download_headers() so that I could avoid using `high' as a dual-purpose inout variable, but that's just a personal choice. Feel free to submit any more patches you like... http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=nntp.c&rev1=1.265&rev2=1.266&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=nntp.h&rev1=1.59&rev2=1.60&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=task-headers.c&rev1=1.149&rev2=1.150&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan&command=DIFF_FRAMESET&file=ChangeLog&rev1=1.1911&rev2=1.1912&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/base&command=DIFF_FRAMESET&file=file-headers.c&rev1=1.60&rev2=1.61&root=/cvs/gnome