After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112609 - fails to build gst/mpeg2enc on Solaris x86 w/o gas
fails to build gst/mpeg2enc on Solaris x86 w/o gas
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.x
Other opensolaris
: Normal normal
: 0.6.x
Assigned To: David Schleef
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-05-09 01:17 UTC by Hidetoshi Tajima
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
changes for solaris native assembler - please test before commit. (143.68 KB, patch)
2003-05-12 18:25 UTC, Hidetoshi Tajima
none Details | Review
a proposed patch - but please don't take change for ffmpeg faiulre as it is. (3.78 KB, patch)
2003-06-11 01:51 UTC, Hidetoshi Tajima
none Details | Review

Description Hidetoshi Tajima 2003-05-09 01:17:48 UTC
With same reason as bug 112607, mpeg2enc plugin
cannot be built on a Soalris x86 where no GNU
assmubler(gas) is installed.
Comment 1 David Schleef 2003-05-09 18:40:34 UTC
Fixed in HEAD
Comment 2 Hidetoshi Tajima 2003-05-09 22:22:54 UTC
*.s herein cause many erros with native as
(/usr/ccs/bin/as) on Solaris.
  - Comments should start with '/' instead of '#'.
  - .global should be .globl.
  - .word should be (perhaps) .value.
Comment 3 David Schleef 2003-05-10 22:07:56 UTC
Could you try to fix this?  It sounds like the changes are
straighforward, but since few (if any) of us have access to a Solaris
assembler, it would be difficult to get it right.
Comment 4 Hidetoshi Tajima 2003-05-12 18:25:00 UTC
Created attachment 16466 [details] [review]
changes for solaris native assembler - please test before commit.
Comment 5 Hidetoshi Tajima 2003-05-12 18:36:19 UTC
Please review the diff. Besides what I mentioned
above, there were a few other errors in fdct_mmx.s.
 - removed .extern - anyway undefined symbosl
   are external.
 - .equ -> .set
 - () -> []

Regards,
Toshi
Comment 6 David Schleef 2003-05-12 23:29:34 UTC
'/' doesn't work with gas except at the beginning of lines, so

  pushl %ebp                              /  save frame pointer

doesn't work.

Perhaps ';' would work for you?
Comment 7 David Schleef 2003-05-12 23:39:06 UTC
Ok, I looked this up.  In gas,

1) Comments start with '#'.

2) Lines are comments if they start with '/', and by extension of 1),
if they start with '#'.

Does Solaris's assembler understand '#' like in

  pushl %ebp                              #  save frame pointer

or do all end-of-line comments need to be converted?
Comment 8 Hidetoshi Tajima 2003-05-13 00:33:57 UTC
Then, how about using `/*' and `*/' in a single line?

Solaris x86 assembly reference manual in http://docs.sun.com says:
 "The assembler ignores all characters following a slash up to the
next occurrence of newline".


Comment 9 David Schleef 2003-05-13 01:30:16 UTC
That requires changing from .s files to .S.  This causes gcc to run
the preprocessor on the file before assembling.  I think that's a good
idea -- then we can use /* */ or //.
Comment 10 David Schleef 2003-05-18 21:36:10 UTC
I've checked in more fixes into HEAD.  Could you test it and tell me
if it compiles now?
Comment 11 Hidetoshi Tajima 2003-06-11 01:50:06 UTC
Sorry for being late...

I just did clean-build of gstreamer and gst-plugins on the HEAD.
Except only a few errors, the build went very well:

In mpeg2enc, there are only two:
 quant_mmx.S:
   - does not seem to like .short. s/.short/.value
     will work.
 fdct_mmx.S:
   - does not like () in expression. [] will work.
 
Other than these, there are some minors at
a few other places.

  - make install fails due to ffmpeg is missing
    at gst-libs/ext/ffmpeg.. Perhaps, this patch is not quite right,
but should do with a
configure check of ffmpeg existance.
  - __inline__ cannnot be resolved at sys/qcam
  - there is no <sys/io.h> on Solaris.

I'll attach a combined patch here. Please take a look and apply.

Reopening...
Comment 12 Hidetoshi Tajima 2003-06-11 01:51:48 UTC
Created attachment 17418 [details] [review]
a proposed patch - but please don't take change for ffmpeg faiulre as it is.
Comment 13 David Schleef 2003-06-11 06:11:34 UTC
Patch to mpeg2enc committed.

The change to ffmpeg seems to have already been done.

qcamsrc has no possibility of working on anything but i386-linux, so I
fixed the test in configure.ac.

Again, if you have additional problems, please reopen the bug or
create a new one.  Thanks.
Comment 14 Hidetoshi Tajima 2003-06-11 16:59:19 UTC
Thanks, I'm going to verify by clean cvs-checkout
and build from the HEAD, and will mark this
verified if okay.

BTW, ffmpeg issue seems still there. The problem
is in its Makefile.am having that install rule
even when USE_FFMPEG is FALSE and FFMPEG_DIR is
NONE. I'm going to create a separete bug report 
for it.
Comment 15 Hidetoshi Tajima 2003-06-11 18:23:56 UTC
Hmm, did you really commit the patch to the HEAD? I don't see fix when
I just run cvs update
Is there a delay due to my using CVSROOT?
:pserver:anonymous@cvs.gstreamer.sourceforge.net:/cvsroot/gstreamer
Comment 16 David Schleef 2003-06-11 19:56:06 UTC
Yes, it was committed.  It wouldn't surprise me if anonymous CVS was
slow; it's run on a different server than ssh CVS.