After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112292 - It is impossible to remove user defined emblems
It is impossible to remove user defined emblems
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Backgrounds Emblems and Themes
2.24.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 136936 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2003-05-05 13:36 UTC by Daniel Thompson
Modified: 2008-12-19 11:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
i ♥ trash (8.27 KB, image/png)
2008-11-19 05:47 UTC, Teppo Turtiainen
  Details
patch for src/nautilus-property-browser.c (1.43 KB, patch)
2008-12-12 16:12 UTC, DESSAI Imrane
none Details | Review
patch for src/nautilus-property-browser.c (1.49 KB, patch)
2008-12-12 17:54 UTC, DESSAI Imrane
none Details | Review

Description Daniel Thompson 2003-05-05 13:36:52 UTC
Description of Problem:

Once a user defined emblem has been created it is
impossible to remove it without hand hacking in
the ~/.icons directory.

Steps to reproduce the problem:
1. Open the Background and Emblems dialog
2. Create a new emblem
3. Try to remove it.

Actual Results:
It is not possible to remove the emblem.

Expected Results:
It should be possible to remove user defined
emblems. I tried using a context menu (there is
none) and dragging the user defined emblem to the
trash (which provokes 112278 instead).

How often does this happen?
Always (it is a UI bug)

Additional Information:
Redhat 9 (with no particular customization)
Comment 1 Elijah Newren 2003-05-10 19:50:05 UTC
I get the same behavior Daniel does.  I added my own emblem following
his instructions, and then couldn't remove it.  I finally found the
files in the .icon directory and deleted them -- and then found that I
had to log out and back in as well to make nautilus realize that the
emblem no longer existed.  [Note that bug 112278, which Daniel
references and filed, looks like notabug to me]

Setting version->2.2.x (I'm using RedHat 9 as well, which run nautilus
2.2.1), changing GNOMEVER2.0->GNOMEVER2.2, I believe severity is
correct, but I'm not sure if priority should be high (annoying
cosmetic bug with no usable workaround), or normal (functionality not
all that important).  I'm going to add the usability keyword (though
I'm not certain this should be done), since this would require an
extra/different user-interface to fix.  Since I'm unsure on the
priority and the usability keyword, I'm leaving the bugsquad keyword off.
Comment 2 James Willcox 2003-06-14 22:26:13 UTC
Hmm, that sucks.

FWIW, you can remove emblems from the emblems sidebar.
Comment 3 Sebastien Bacher 2003-11-28 23:38:41 UTC
Still here with nautilus 2.4.1 => GNOMEVER2.4
Comment 4 Martin Wehner 2004-05-16 23:12:44 UTC
*** Bug 136936 has been marked as a duplicate of this bug. ***
Comment 5 Martin Wehner 2004-05-16 23:14:41 UTC
Still true for 2.6.x; Upgrading fields.
Comment 6 Vincent 2004-10-12 09:40:20 UTC
Still here in GNOME 2.8 (GARNOME).
From searches through the net, I also came on documentation saying that the
rubber emblem (titled "remove", it does not seem to be an emblem BTW since it is
bigger than the others) is meant to be dragged on to an emblem that the user
wants to delete. This does not work.
Comment 7 Sebastien Bacher 2005-05-21 23:25:47 UTC
do you still have this issue? 
Comment 8 Daniel Thompson 2005-05-22 15:40:53 UTC
This issue is still present for me in FC3 (Nautilus 2.8.1). The rubber emblem is
used to remove emblems from other files. It cannot be used to delete remove
emblems themselves.
Comment 9 Thomas Winwood 2005-12-20 05:05:30 UTC
Still present in Ubuntu 6.04 (Nautilus 2.13.3).
Comment 10 Christian Neumair 2006-02-26 08:51:23 UTC
Scary. Updating version.
Comment 11 Thomas Winwood 2006-03-04 18:53:09 UTC
Still present in Nautilus 2.13.92 - I guess this won't be addressed in time for 2.14 release?
Comment 12 Christian Neumair 2006-03-05 13:07:45 UTC
Yep, it missed 2.14, milestoning to 2.16. Note that it is currently possible to delete emblems using the emblem sidebar (context menu->delete), IIRC the code for the sidebar is very much different from the code we use in the properties dialog.
Comment 13 Teppo Turtiainen 2006-09-03 17:14:06 UTC
Removing emblems should really work for all emblems, not just user defined ones.
Comment 14 Rostislav Matl 2007-10-10 14:03:28 UTC
I have 2.18 and still not see any way how to remove an emblem except the emblems sidebar (I've looked for it for a while as I has not used it ever and I'm uncertain if anybody does). Also the non-user emblems are no removable even from the sidebar -  very annoying with the new duplicit items "important" and  "stockmail-priority-high" (very annoying).

I'm not sure what happens if I remove emblem - is it cleared from icon view ? If so, it would be necessary to add ability to change emblem icon only.
Comment 15 Alejandro 2008-10-14 02:24:24 UTC
This bug is still present in Nautilus 2.22.5.1 (Gnome 2.22.3).

Any chance to get this fixed? ._.
Comment 16 Emmanuel Fleury 2008-11-18 21:23:28 UTC
Still here on 2.20.0...

In fact, I tried to slide the emblem to the trash and it got attached to the trash icon with no way to remove it from the trash icon... (funny! :)).
Comment 17 Teppo Turtiainen 2008-11-19 05:47:06 UTC
Created attachment 123011 [details]
i ♥ trash

(In reply to comment #16)
> In fact, I tried to slide the emblem to the trash and it got attached to the
> trash icon with no way to remove it from the trash icon... (funny! :)).

Yes, pretty funny. It seems you can remove the emblem by dragging the Erase emblem to the trash.
Comment 18 Emmanuel Fleury 2008-11-19 06:31:07 UTC
Yes, in fact I used Bug 48501 to remove it. :)
Comment 19 DESSAI Imrane 2008-12-12 16:11:40 UTC
We tried to fix this bug (see the patch file attachment : allowing_removing_personnal_emblems.diff).

The "remove" button now appears properly for the three categories (pattern, colors and emblems).

The awaited behavior for deleting personnal emblems is reached. But it seems that callback functions connected to the "remove" button for "pattern" and "colors" categories are bugged. 

Can anyone confirm those things ?
Comment 20 DESSAI Imrane 2008-12-12 16:12:59 UTC
Created attachment 124532 [details] [review]
patch for src/nautilus-property-browser.c
Comment 21 DESSAI Imrane 2008-12-12 17:45:50 UTC
(In reply to comment #19)
> We tried to fix this bug (see the patch file attachment :
> allowing_removing_personnal_emblems.diff).
> 
> The "remove" button now appears properly for the three categories (pattern,
> colors and emblems).
> 
> The awaited behavior for deleting personnal emblems is reached. But it seems
> that callback functions connected to the "remove" button for "pattern" and
> "colors" categories are bugged. 
> 
> Can anyone confirm those things ?
> 

In fact, we've made a mistake.
Now with the new patch, behaviors for "pattern" and "colors" are correct.

The "remove" button for emblems is ok !

But we noticed that if there is no "local" (or personnal) colors the remove button is hidden. If there is one, the button appears. If you click on that button, only personnal colors are shown.
For emblems, things are different. The remove button is always shown and when you click on it, all emblems are shows (not only personnal ones).
Is it a "new" bug or is it out of this topic (perhaps in the wish-list)?

Comment 22 DESSAI Imrane 2008-12-12 17:54:10 UTC
Created attachment 124542 [details] [review]
patch for src/nautilus-property-browser.c
Comment 23 Alexander Larsson 2008-12-19 11:36:19 UTC
2008-12-19  Alexander Larsson  <alexl@redhat.com>

        * src/nautilus-property-browser.c:
	Allow deleting of custom emblems. (#112292)
	Patch from DESSAI Imrane 

I also added a check for nautilus_emblem_can_remove_emblem() so we only show the button if there are removable emblems and only show the removable emblems when delete is pressed.