After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 111906 - custom actions don't appear in the toolbar overflow menus.
custom actions don't appear in the toolbar overflow menus.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2003-04-30 05:53 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4


Attachments
Initial stab at working this out (2.04 KB, patch)
2003-05-01 17:05 UTC, lwillis
none Details | Review
Implement overflow menu item for bookmarks (9.54 KB, patch)
2003-06-11 19:35 UTC, Christian Persch
none Details | Review

Description Dave Bordoley [Not Reading Bug Mail] 2003-04-30 05:53:13 UTC
custom actions don't appear in the toolbar overflow menus.
Comment 1 Marco Pesenti Gritti 2003-04-30 08:49:54 UTC
Yeah we need to implement them in ephy-bookmark-action and ephy-topic-
action. It should not be too hard.
Comment 2 Dave Bordoley [Not Reading Bug Mail] 2003-04-30 18:35:42 UTC
ephy-go-action, ephy-location-action and ephy-spinner-action too.
Comment 3 lwillis 2003-05-01 17:05:28 UTC
Created attachment 16174 [details] [review]
Initial stab at working this out
Comment 4 lwillis 2003-05-01 17:07:31 UTC
Guys, I've taken an initial stab at a patch for this. I appreciate
it's not yet tidy!  So far I've got the menu items to appear - but
nothing happens when I select them (And I get a *load* of errors on
the terminal output). If you can give me some pointers I'm happy to
work on this and get it into a useable state[1] - let me know what you
think ....

Comment 5 Marco Pesenti Gritti 2003-05-02 08:18:12 UTC
I dont think you need to do this, eggaction will do it for you I 
think.
It would seem you can just override create_menu_item and do something 
like this in it:

GtkWidget *menu_item;

menu_item = (* EGG_ACTION_GET_CLASS (action)->create_menu_item) 
(action);
set_label etc ...

You could also avoid to call the parent method and create the menu 
item yourself... it would work anyway but maybe this is cleaner.
Comment 6 Dave Bordoley [Not Reading Bug Mail] 2003-05-19 06:50:06 UTC
marco i think to get this working we need to convert our custom action
into egg_tool_items so that we can over the create_menu_proxy function.
Comment 7 Dave Bordoley [Not Reading Bug Mail] 2003-05-19 06:51:13 UTC
as a side note, i do think it would be kind of cool to implement a
custom menu entry for the address entry so that when its in the menu
you can still enter in addresses.
Comment 8 Marco Pesenti Gritti 2003-05-19 06:59:53 UTC
I think eggmenu create eggtoolitems ... not sure though, need to check.
Comment 9 Christian Persch 2003-06-11 19:35:53 UTC
Created attachment 17468 [details] [review]
Implement overflow menu item for bookmarks
Comment 10 Christian Persch 2003-07-06 15:32:23 UTC
Toolbar overflow menu items are now implemented for bookmarks,
bookmark topics, the zoom control and the go button. The spinner and
the location entry _never_ overflow (the spinner because it's
pack_end, and the location entry because it's expandable).