After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 111692 - [0.6.2 candidate] Fix wavparse
[0.6.2 candidate] Fix wavparse
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.1
Other All
: Normal normal
: 0.6.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-04-27 10:50 UTC by Ronald Bultje
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (2.57 KB, patch)
2003-04-27 10:51 UTC, Ronald Bultje 		none Details | Review
updated patch to only handle PCM (2.63 KB, patch)
2003-04-27 10:57 UTC, Ronald Bultje 		none Details | Review
use GUINT16_FROM_LE() (3.10 KB, patch)
2003-04-27 11:12 UTC, Ronald Bultje 		none Details | Review
fix last floating G_LITTLE_ENDIAN (oops) (3.48 KB, patch)
2003-04-27 11:24 UTC, Ronald Bultje 		none Details | Review
example wav file that BE machines don't like (500.00 KB, application/octet-stream)
2003-04-27 11:57 UTC, Andres Salomon 		  Details
s/guint16/gint16/ (3.48 KB, patch)
2003-04-27 12:02 UTC, Ronald Bultje 		none Details | Review
Company's code added (3.75 KB, patch)
2003-04-27 12:19 UTC, Ronald Bultje 		none Details | Review
more company finetuning (3.25 KB, patch)
2003-04-27 12:27 UTC, Ronald Bultje 		none Details | Review
add timestamping (3.31 KB, patch)
2003-04-27 12:42 UTC, Ronald Bultje 		none Details | Review

Description Ronald Bultje 2003-04-27 10:50:42 UTC 
Wavparse doesn't byteswap the data for bigendian machines. It also gives a
property that only allows LITTLE_ENDIAN, but this effectively kills
wavparse on big endian machines (i.e. it's useless). Attached patch fixes this.
Comment 1 Ronald Bultje 2003-04-27 10:51:03 UTC 
Created attachment 16046 [details] [review]
patch
Comment 2 Ronald Bultje 2003-04-27 10:55:54 UTC 
Oh, this will break if there's mp3 audio in the wav file - I don't
know wavparse detects that... It'd be another if statement in
gst_wavparse_push().
Comment 3 Ronald Bultje 2003-04-27 10:57:46 UTC 
Created attachment 16047 [details] [review]
updated patch to only handle PCM
Comment 4 Ronald Bultje 2003-04-27 11:12:45 UTC 
Created attachment 16048 [details] [review]
use GUINT16_FROM_LE()
Comment 5 Ronald Bultje 2003-04-27 11:24:25 UTC 
Created attachment 16049 [details] [review]
fix last floating G_LITTLE_ENDIAN (oops)
Comment 6 Andres Salomon 2003-04-27 11:57:13 UTC 
Created attachment 16050 [details]
example wav file that BE machines don't like
Comment 7 Ronald Bultje 2003-04-27 12:02:24 UTC 
Created attachment 16053 [details] [review]
s/guint16/gint16/
Comment 8 Ronald Bultje 2003-04-27 12:19:03 UTC 
Created attachment 16055 [details] [review]
Company's code added
Comment 9 Ronald Bultje 2003-04-27 12:27:58 UTC 
Created attachment 16056 [details] [review]
more company finetuning
Comment 10 Ronald Bultje 2003-04-27 12:42:01 UTC 
Created attachment 16057 [details] [review]
add timestamping
Comment 11 Ronald Bultje 2003-04-28 08:42:16 UTC 
Fixed.