After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 111286 - cancel_arrow_animation threadlocks
cancel_arrow_animation threadlocks
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
2.2.x
Other other
: Normal major
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
: 125020 (view as bug list)
Depends on:
Blocks: 112280
 
 
Reported: 2003-04-21 19:04 UTC by Peter Bloomfield
Modified: 2011-02-04 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested patch (1.63 KB, patch)
2003-04-22 14:38 UTC, Peter Bloomfield 		none Details | Review
Sorry--missing semicolon in the previous patch. (1.64 KB, patch)
2003-05-31 14:36 UTC, Peter Bloomfield 		none Details | Review

Description Peter Bloomfield 2003-04-21 19:04:01 UTC 
cancel_arrow_animation calls expand_collapse_timeout, which (as a timeout
handler) calls GDK_THREADS_ENTER. However, cancel_arrow_animation is called
within a signal handler, which already holds the gdk lock. If this code is
ever called, it's an instant threadlock. The situation where it's called
must be rare; I haven't seen it, but one Balsa user has: 

http://mail.gnome.org/archives/balsa-list/2003-April/msg00085.html
Comment 1 Peter Bloomfield 2003-04-22 14:38:08 UTC 
Created attachment 15904 [details] [review]
Suggested patch
Comment 2 Pawel Salek 2003-05-06 08:43:23 UTC 
This patch applies to gtk-2.2.1 - changing the version and increasing
severity.
Comment 3 Kristian Rietveld 2003-05-22 22:55:16 UTC 
Patch doesn't look right to me. But maybe I am confused because it's
late. Need to look again when I am awake ...

Putting on 2.2.2 for now.
Comment 4 Peter Bloomfield 2003-05-22 23:24:42 UTC 
Hi Kris!

Here are some other people who found the patch helpful:

http://mail.gnome.org/archives/balsa-list/2003-May/msg00039.html

and the rest of the thread.

Peter
Comment 5 Peter Bloomfield 2003-05-31 14:36:43 UTC 
Created attachment 17014 [details] [review]
Sorry--missing semicolon in the previous patch.
Comment 6 Kristian Rietveld 2003-06-06 21:45:19 UTC 
Sorry Peter, your patch is completely correct. I was indeed already
sleeping when I looked at it last time P:.

Committed to gtk-2-2 and HEAD.

Thanks for the patch, and I won't ever look at patches again when I
should be sleeping (: Apologies.
Comment 7 Pawel Salek 2003-11-06 08:07:48 UTC 
*** Bug 125020 has been marked as a duplicate of this bug. ***