After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 111103 - Proposed keyboard preferences HIGification changes
Proposed keyboard preferences HIGification changes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
2.2.x
Other All
: High minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-04-18 20:09 UTC by Christian Neumair
Modified: 2003-08-01 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch against HEAD. (86.15 KB, patch)
2003-04-18 20:10 UTC, Christian Neumair
none Details | Review
Screenshot illustrating the changes. (22.28 KB, image/png)
2003-04-18 20:11 UTC, Christian Neumair
  Details
Screenshot illustrating the changes. (22.28 KB, image/png)
2003-04-18 20:12 UTC, Christian Neumair
  Details
Jonathan, I am attaching a patch to add the two missing pixels between the vbox and action area of the preferences dialog. (1.33 KB, patch)
2003-08-01 04:22 UTC, Dennis Cranston
none Details | Review

Description Christian Neumair 2003-04-18 20:09:45 UTC
I HIGified the keyboard preferences dialog.
See attachment.

regs,
 Chris
Comment 1 Christian Neumair 2003-04-18 20:10:32 UTC
Created attachment 15836 [details] [review]
Proposed patch against HEAD.
Comment 2 Christian Neumair 2003-04-18 20:11:30 UTC
Created attachment 15837 [details]
Screenshot illustrating the changes.
Comment 3 Christian Neumair 2003-04-18 20:12:15 UTC
Created attachment 15838 [details]
Screenshot illustrating the changes.
Comment 4 Christian Neumair 2003-04-18 20:19:46 UTC
Sorry, sent last attachment twice.
Changing some but data.

regs,
 Chris
Comment 5 Kjartan Maraas 2003-04-22 23:15:07 UTC
Is this ok to commit?
Comment 6 James T. Richardson, Jr. 2003-06-24 02:13:10 UTC
I personally think that the controls of this dialog should be
identical to the controls in the Keyboard accessability pane. (with
the spin control). 

It would definatly make more sense that they both offer the same
functionality.
Comment 7 Jody Goldberg 2003-06-24 20:42:40 UTC
1) I would also prefer that the layout match the a11y capplet

2) Lets hold off doing any glade changes in here for a bit
There are 2 major patches coming in shortly
Comment 8 Kjartan Maraas 2003-07-09 16:43:26 UTC
Have the major patches landed? Manny, could you post a description of
the changes please?
Comment 9 Jonathan Blandford 2003-07-31 21:11:48 UTC
There has been HIG work done on this capplet (and Dr. Wright merged
in).  The patch doesn't apply anymore.  It looks pretty similar to the
patch that Manny proposed, though the icons are now gone (they were
never particularly nice.)  Can I close this, Manny?  Is it HIGGY enough?
Comment 10 Christian Neumair 2003-07-31 23:04:19 UTC
It looks really nice except that Dennis forgot again to add two px
between the action area and the content widget. Please, remember that
- it's really annoying to point out such tiny issues more than once.

regs,
 Chris
Comment 11 Dennis Cranston 2003-08-01 04:03:13 UTC
Christian,

Why are you such an asshole?  This change went in to cvs before you
told me about the 2 pixel problem. 

Dennis
Comment 12 Dennis Cranston 2003-08-01 04:22:18 UTC
Created attachment 18804 [details] [review]
Jonathan,  I am attaching a patch to add the two missing pixels between the vbox and action area of the preferences dialog.
Comment 13 Christian Neumair 2003-08-01 08:18:21 UTC
I don't think I'm in need of discussing with people who insult me in
such an incongruous way.

regs,
 Chris
Comment 14 Jonathan Blandford 2003-08-01 19:06:36 UTC
Patch applied.  Closing this bug.