GNOME Bugzilla – Bug 111103
Proposed keyboard preferences HIGification changes
Last modified: 2003-08-01 19:06:36 UTC
I HIGified the keyboard preferences dialog. See attachment. regs, Chris
Created attachment 15836 [details] [review] Proposed patch against HEAD.
Created attachment 15837 [details] Screenshot illustrating the changes.
Created attachment 15838 [details] Screenshot illustrating the changes.
Sorry, sent last attachment twice. Changing some but data. regs, Chris
Is this ok to commit?
I personally think that the controls of this dialog should be identical to the controls in the Keyboard accessability pane. (with the spin control). It would definatly make more sense that they both offer the same functionality.
1) I would also prefer that the layout match the a11y capplet 2) Lets hold off doing any glade changes in here for a bit There are 2 major patches coming in shortly
Have the major patches landed? Manny, could you post a description of the changes please?
There has been HIG work done on this capplet (and Dr. Wright merged in). The patch doesn't apply anymore. It looks pretty similar to the patch that Manny proposed, though the icons are now gone (they were never particularly nice.) Can I close this, Manny? Is it HIGGY enough?
It looks really nice except that Dennis forgot again to add two px between the action area and the content widget. Please, remember that - it's really annoying to point out such tiny issues more than once. regs, Chris
Christian, Why are you such an asshole? This change went in to cvs before you told me about the 2 pixel problem. Dennis
Created attachment 18804 [details] [review] Jonathan, I am attaching a patch to add the two missing pixels between the vbox and action area of the preferences dialog.
I don't think I'm in need of discussing with people who insult me in such an incongruous way. regs, Chris
Patch applied. Closing this bug.